Better handle registry referencing non-existing codestarts

We need to be a lot more solid when the registry is referencing
non-existing codestarts.
Which can happen if an extension is pointing to a non-existing codestart.

The patch is extremely small but we have to push the logger there thus
why patch is larger than expected.

Related to
https://quarkusio.zulipchat.com/#narrow/channel/187030-users/topic/.60quarkus.20create.20cli.60.20is.20possibly.20broken.3F/with/517462042

Author: gsmet

devtools/maven/src/main/java/io/quarkus/maven/CreateJBangMojo.java

@@ -113,7 +113,7 @@ public void execute() throws MojoExecutionException {
             throw new MojoExecutionException("Failed to resolve Quarkus extension catalog", e);
         }
 
-        final List<ResourceLoader> codestartsResourceLoader = codestartLoadersBuilder()
+        final List<ResourceLoader> codestartsResourceLoader = codestartLoadersBuilder(log)
                 .catalog(catalog)
                 .artifactResolver(mvn)
                 .build();

devtools/maven/src/main/java/io/quarkus/maven/CreateProjectMojo.java

@@ -296,7 +296,7 @@ public void execute() throws MojoExecutionException {
             catalog = CreateProjectHelper.completeCatalog(catalog, extensions, mvn);
             sanitizeOptions();
 
-            final List<ResourceLoader> codestartsResourceLoader = codestartLoadersBuilder()
+            final List<ResourceLoader> codestartsResourceLoader = codestartLoadersBuilder(log)
                     .catalog(catalog)
                     .artifactResolver(mvn)
                     .build();

devtools/maven/src/main/java/io/quarkus/maven/QuarkusProjectMojoBase.java

@@ -103,7 +103,7 @@ public void execute() throws MojoExecutionException {
         } else {
             final ExtensionCatalog extensionCatalog = resolveExtensionCatalog();
             final List<ResourceLoader> codestartsResourceLoader = CodestartResourceLoadersBuilder
-                    .codestartLoadersBuilder()
+                    .codestartLoadersBuilder(log)
                     .artifactResolver(artifactResolver())
                     .catalog(extensionCatalog)
                     .build();

independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/codestarts/extension/QuarkusExtensionCodestartCatalog.java

@@ -12,6 +12,7 @@
 import io.quarkus.devtools.codestarts.Codestart;
 import io.quarkus.devtools.codestarts.DataKey;
 import io.quarkus.devtools.codestarts.core.GenericCodestartCatalog;
+import io.quarkus.devtools.messagewriter.MessageWriter;
 
 public final class QuarkusExtensionCodestartCatalog extends GenericCodestartCatalog<QuarkusExtensionCodestartProjectInput> {
 
@@ -78,9 +79,9 @@ public enum Tooling implements DataKey {
         GIT
     }
 
-    public static QuarkusExtensionCodestartCatalog fromBaseCodestartsResources()
+    public static QuarkusExtensionCodestartCatalog fromBaseCodestartsResources(MessageWriter log)
             throws IOException {
-        final Map<String, Codestart> codestarts = loadCodestartsFromResources(getCodestartResourceLoaders(),
+        final Map<String, Codestart> codestarts = loadCodestartsFromResources(getCodestartResourceLoaders(log),
                 QUARKUS_EXTENSION_CODESTARTS_DIR);
         return new QuarkusExtensionCodestartCatalog(codestarts.values());
     }

independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/codestarts/jbang/QuarkusJBangCodestartCatalog.java

@@ -12,6 +12,7 @@
 import io.quarkus.devtools.codestarts.Codestart;
 import io.quarkus.devtools.codestarts.DataKey;
 import io.quarkus.devtools.codestarts.core.GenericCodestartCatalog;
+import io.quarkus.devtools.messagewriter.MessageWriter;
 import io.quarkus.platform.descriptor.loader.json.ResourceLoader;
 
 public final class QuarkusJBangCodestartCatalog extends GenericCodestartCatalog<QuarkusJBangCodestartProjectInput> {
@@ -48,9 +49,9 @@ private QuarkusJBangCodestartCatalog(Collection<Codestart> codestarts) {
         super(codestarts);
     }
 
-    public static QuarkusJBangCodestartCatalog fromBaseCodestartsResources()
+    public static QuarkusJBangCodestartCatalog fromBaseCodestartsResources(MessageWriter log)
             throws IOException {
-        final Map<String, Codestart> codestarts = loadCodestartsFromResources(getCodestartResourceLoaders(),
+        final Map<String, Codestart> codestarts = loadCodestartsFromResources(getCodestartResourceLoaders(log),
                 QUARKUS_JBANG_CODESTARTS_DIR);
         return new QuarkusJBangCodestartCatalog(codestarts.values());
     }

independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/codestarts/quarkus/QuarkusCodestartCatalog.java

@@ -10,7 +10,6 @@
 import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -28,6 +27,7 @@
 import io.quarkus.devtools.codestarts.CodestartType;
 import io.quarkus.devtools.codestarts.DataKey;
 import io.quarkus.devtools.codestarts.core.GenericCodestartCatalog;
+import io.quarkus.devtools.messagewriter.MessageWriter;
 import io.quarkus.devtools.project.extensions.Extensions;
 import io.quarkus.maven.dependency.ArtifactCoords;
 import io.quarkus.platform.catalog.processor.ExtensionProcessor;
@@ -86,22 +86,23 @@ private QuarkusCodestartCatalog(Collection<Codestart> codestarts,
         this.extensionsMapping = extensionsMapping;
     }
 
-    public static QuarkusCodestartCatalog fromBaseCodestartsResources(Map<String, Extension> extensionsMapping)
+    public static QuarkusCodestartCatalog fromBaseCodestartsResources(MessageWriter log,
+            Map<String, Extension> extensionsMapping)
             throws IOException {
-        final Map<String, Codestart> codestarts = loadCodestartsFromResources(getCodestartResourceLoaders(),
+        final Map<String, Codestart> codestarts = loadCodestartsFromResources(getCodestartResourceLoaders(log),
                 QUARKUS_CODESTARTS_DIR);
         return new QuarkusCodestartCatalog(codestarts.values(), extensionsMapping);
     }
 
-    public static QuarkusCodestartCatalog fromBaseCodestartsResources()
+    public static QuarkusCodestartCatalog fromBaseCodestartsResources(MessageWriter log)
             throws IOException {
-        return fromBaseCodestartsResources(Collections.emptyMap());
+        return fromBaseCodestartsResources(log, Map.of());
     }
 
     public static QuarkusCodestartCatalog fromExtensionsCatalogAndDirectories(
-            ExtensionCatalog catalog, Collection<Path> directories)
+            MessageWriter log, ExtensionCatalog catalog, Collection<Path> directories)
             throws IOException {
-        final List<ResourceLoader> loaders = getCodestartResourceLoaders(catalog);
+        final List<ResourceLoader> loaders = getCodestartResourceLoaders(log, catalog);
         final Map<String, Codestart> codestarts = loadCodestartsFromResources(loaders,
                 QUARKUS_CODESTARTS_DIR);
         for (Path directory : directories) {

independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateExtensionCommandHandler.java

@@ -63,7 +63,7 @@ public QuarkusCommandOutcome execute(MessageWriter log)
             throws QuarkusCommandException {
         try {
             final QuarkusExtensionCodestartCatalog catalog = QuarkusExtensionCodestartCatalog
-                    .fromBaseCodestartsResources();
+                    .fromBaseCodestartsResources(log);
             catalog.createProject(input).generate(newExtensionDir);
 
             final String extensionDirName = newExtensionDir.getFileName().toString();

independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/CodestartResourceLoadersBuilder.java

@@ -19,6 +19,7 @@
 
 import io.quarkus.bootstrap.resolver.maven.MavenArtifactResolver;
 import io.quarkus.bootstrap.util.DependencyUtils;
+import io.quarkus.devtools.messagewriter.MessageWriter;
 import io.quarkus.platform.descriptor.loader.json.ResourceLoader;
 import io.quarkus.registry.catalog.Extension;
 import io.quarkus.registry.catalog.ExtensionCatalog;
@@ -33,6 +34,7 @@ public final class CodestartResourceLoadersBuilder {
     private MavenArtifactResolver artifactResolver;
     private String baseCodestartsArtifactCoords = BASE_CODESTARTS_ARTIFACT_COORDS;
     private Collection<String> extraCodestartsArtifactCoords = new ArrayList<>();
+    private MessageWriter log;
 
     private static String retrieveBaseCodestartsArtifactCoords() {
         final String artifact = PropertiesUtil.getProperty(BASE_CODESTARTS_ARTIFACT_PROPERTY);
@@ -52,19 +54,20 @@ private static String retrieveBaseCodestartsArtifactCoords() {
         }
     }
 
-    private CodestartResourceLoadersBuilder() {
+    private CodestartResourceLoadersBuilder(MessageWriter log) {
+        this.log = log;
     }
 
-    public static CodestartResourceLoadersBuilder codestartLoadersBuilder() {
-        return new CodestartResourceLoadersBuilder();
+    public static CodestartResourceLoadersBuilder codestartLoadersBuilder(MessageWriter log) {
+        return new CodestartResourceLoadersBuilder(log);
     }
 
-    public static List<ResourceLoader> getCodestartResourceLoaders() {
-        return codestartLoadersBuilder().build();
+    public static List<ResourceLoader> getCodestartResourceLoaders(MessageWriter log) {
+        return codestartLoadersBuilder(log).build();
     }
 
-    public static List<ResourceLoader> getCodestartResourceLoaders(ExtensionCatalog catalog) {
-        return codestartLoadersBuilder().catalog(catalog).build();
+    public static List<ResourceLoader> getCodestartResourceLoaders(MessageWriter log, ExtensionCatalog catalog) {
+        return codestartLoadersBuilder(log).catalog(catalog).build();
     }
 
     public CodestartResourceLoadersBuilder catalog(ExtensionCatalog catalog) {
@@ -94,13 +97,14 @@ public CodestartResourceLoadersBuilder addExtraCodestartsArtifactCoords(Collecti
 
     public List<ResourceLoader> build() {
         return getCodestartResourceLoaders(baseCodestartsArtifactCoords, extraCodestartsArtifactCoords, catalog,
-                artifactResolver == null ? QuarkusProjectHelper.artifactResolver() : artifactResolver);
+                artifactResolver == null ? QuarkusProjectHelper.artifactResolver() : artifactResolver, log);
     }
 
     private static List<ResourceLoader> getCodestartResourceLoaders(String baseCodestartsArtifactCoords,
             Collection<String> extraCodestartsArtifactCoords,
             ExtensionCatalog catalog,
-            MavenArtifactResolver mvn) {
+            MavenArtifactResolver mavenArtifactResolver,
+            MessageWriter log) {
 
         final Map<String, Artifact> codestartsArtifacts = new LinkedHashMap<>();
 
@@ -146,10 +150,11 @@ private static List<ResourceLoader> getCodestartResourceLoaders(String baseCodes
         final List<ResourceLoader> codestartResourceLoaders = new ArrayList<>(codestartsArtifacts.size());
         for (Artifact a : codestartsArtifacts.values()) {
             try {
-                final File artifactFile = mvn.resolve(a).getArtifact().getFile();
+                final File artifactFile = mavenArtifactResolver.resolve(a).getArtifact().getFile();
                 codestartResourceLoaders.add(resolveFileResourceLoader(artifactFile));
             } catch (Exception e) {
-                throw new RuntimeException("Failed to resolve codestart artifact " + a, e);
+                log.warn("Unable to resolve codestart artifact for %s: %s", a, e.getMessage());
+                continue;
             }
         }
         return codestartResourceLoaders;

independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/QuarkusProjectHelper.java

@@ -146,7 +146,7 @@ public static QuarkusProject getProject(Path projectDir, ExtensionCatalog catalo
     public static QuarkusProject getProject(Path projectDir, ExtensionCatalog catalog, BuildTool buildTool,
             JavaVersion javaVersion,
             MessageWriter log) {
-        return QuarkusProject.of(projectDir, catalog, getCodestartResourceLoaders(catalog),
+        return QuarkusProject.of(projectDir, catalog, getCodestartResourceLoaders(log, catalog),
                 log, buildTool, javaVersion);
     }
 
@@ -161,7 +161,7 @@ public static ExtensionCatalog resolveExtensionCatalog() throws RegistryResoluti
     public static QuarkusProject getProject(Path projectDir, ExtensionCatalog catalog, ExtensionManager extManager,
             JavaVersion javaVersion,
             MessageWriter log) {
-        return QuarkusProject.of(projectDir, catalog, getCodestartResourceLoaders(catalog),
+        return QuarkusProject.of(projectDir, catalog, getCodestartResourceLoaders(log, catalog),
                 log, extManager, javaVersion);
     }
 

independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/buildfile/MavenProjectBuildFile.java

@@ -121,7 +121,7 @@ public static QuarkusProject getProject(Artifact projectPom, Model projectModel,
         }
         final MavenProjectBuildFile extensionManager = new MavenProjectBuildFile(projectDir, extensionCatalog,
                 projectModel, deps, managedDeps, projectProps, projectPom == null ? null : artifactResolver);
-        final List<ResourceLoader> codestartResourceLoaders = codestartLoadersBuilder().catalog(extensionCatalog)
+        final List<ResourceLoader> codestartResourceLoaders = codestartLoadersBuilder(log).catalog(extensionCatalog)
                 .artifactResolver(artifactResolver).build();
         final JavaVersion javaVersion = resolveJavaVersion(projectProps);
         return QuarkusProject.of(projectDir, extensionCatalog,