Skip to content

Commit 508f615

Browse files
cescoffierDavideD
authored andcommitted
Do not register the Hot Reload Handler into the Management Interface router
This commit removes the registration of the hot reload handler from the management interface router. The handler is associated with the main router, can potentially block processing tasks. Fix quarkusio#48151 and quarkiverse/quarkus-logging-manager#359.
1 parent 430a29a commit 508f615

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/devmode/management/LiveReloadManagementTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@
66

77
import org.awaitility.Awaitility;
88
import org.jboss.shrinkwrap.api.asset.StringAsset;
9+
import org.junit.jupiter.api.Disabled;
910
import org.junit.jupiter.api.Test;
1011
import org.junit.jupiter.api.extension.RegisterExtension;
1112

1213
import io.quarkus.test.QuarkusDevModeTest;
1314
import io.restassured.RestAssured;
1415

16+
@Disabled("See https://github.com/quarkusio/quarkus/pull/48171")
1517
public class LiveReloadManagementTest {
1618

1719
private static final String APP_PROPS = """

extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,7 @@ public void handle(RoutingContext event) {
563563
var mr = managementRouter.getValue();
564564
boolean hasManagementRoutes = !mr.getRoutes().isEmpty();
565565

566-
addHotReplacementHandlerIfNeeded(mr);
566+
// We do not add the hotreload handler on the management interface
567567

568568
mr.route().last().failureHandler(
569569
new QuarkusErrorHandler(launchMode.isDevOrTest(), decorateStacktrace(launchMode, logBuildTimeConfig),

0 commit comments

Comments
 (0)