Fails to build from source on Debian Linux (daemons.c)

[ndrew222]

I'm on Debian Linux and trying to compile the source from the modern-rogue branch.
uname -a output:

Linux debianMac 6.12.17-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.12.17-1 (2025-03-01) x86_64 GNU/Linux

gcc output:

$ make
gcc -g -O2  -DHAVE_CONFIG_H  -c daemons.c
daemons.c: In function ‘swander’:
daemons.c:55:18: error: passing argument 1 of ‘start_daemon’ from incompatible pointer type [-Wincompatible-pointer-types]
   55 |     start_daemon(rollwand, 0, BEFORE);
      |                  ^~~~~~~~
      |                  |
      |                  void (*)(void)
In file included from daemons.c:14:
rogue.h:654:29: note: expected ‘void (*)(int)’ but argument is of type ‘void (*)(void)’
  654 | void    start_daemon(void (*func)(int), int arg, int type);
      |                      ~~~~~~~^~~~~~~~~~
In file included from rogue.h:13:
extern.h:145:9: note: ‘rollwand’ declared here
  145 | void    rollwand();
      |         ^~~~~~~~
daemons.c: In function ‘rollwand’:
daemons.c:73:18: error: passing argument 1 of ‘fuse’ from incompatible pointer type [-Wincompatible-pointer-types]
   73 |             fuse(swander, 0, WANDERTIME, BEFORE);
      |                  ^~~~~~~
      |                  |
      |                  void (*)(void)
rogue.h:570:21: note: expected ‘void (*)(int)’ but argument is of type ‘void (*)(void)’
  570 | void    fuse(void (*func)(int), int arg, int time, int type);
      |              ~~~~~~~^~~~~~~~~~
daemons.c:53:1: note: ‘swander’ declared here
   53 | swander()
      | ^~~~~~~
make: *** [Makefile:130: daemons.o] Error 1

[ndrew222]

So it compiles when I do:

git reset --hard
git clean -fd
./configure
sed -e 's/^CFLAGS=/CFLAGS= -std=gnu89/' Makefile > Makefile.tmp && mv Makefile.tmp Makefile
make

However, using the autogenerated ./configure using

autoreconf -fiv

it fails to compile. I'm not sure what's the problem, but at least ./configure works.

[ndrew222]

this diff seems to fix the ./configure script into providing a working Makefile

diff --git a/configure b/configure
index a7b95e7..d11c874 100755
--- a/configure
+++ b/configure
@@ -2692,13 +2692,13 @@ if test "$ac_test_CFLAGS" = set; then
   CFLAGS=$ac_save_CFLAGS
 elif test $ac_cv_prog_cc_g = yes; then
   if test "$GCC" = yes; then
-    CFLAGS="-g -O2"
+    CFLAGS="-g -O2 -std=gnu89"
   else
     CFLAGS="-g"
   fi
 else
   if test "$GCC" = yes; then
-    CFLAGS="-O2"
+    CFLAGS="-O2 -std=gnu89"
   else
     CFLAGS=
   fi