refactor(nvim): Use fallback in flatten_table_to_string for empty error

Author: Davidyz

lua/vectorcode/init.lua

@@ -190,7 +190,7 @@ function M.check(check_item, stdout_cb)
     if type(stdout_cb) == "function" then
       stdout_cb({
         stdout = utils.flatten_table_to_string(result),
-        stderr = utils.flatten_table_to_string(error),
+        stderr = utils.flatten_table_to_string(error, "Unknown error."),
         code = code,
         signal = signal,
       })

lua/vectorcode/integrations/codecompanion/files_ls_tool.lua

@@ -43,7 +43,7 @@ return function(opts)
             cb({ status = "success", data = result })
           else
             if type(error) == "table" then
-              error = utils.flatten_table_to_string(error)
+              error = utils.flatten_table_to_string(error, "Unknown error.")
             end
             cb({
               status = "error",

lua/vectorcode/integrations/codecompanion/ls_tool.lua

@@ -45,7 +45,7 @@ return function(opts)
             cb({ status = "success", data = result })
           else
             if type(error) == "table" then
-              error = utils.flatten_table_to_string(error)
+              error = utils.flatten_table_to_string(error, "Unknown error.")
             end
             cb({
               status = "error",

lua/vectorcode/integrations/codecompanion/prompts/init.lua

@@ -131,14 +131,12 @@ Here's my question:
                 vc_config.notify_opts
               )
             elseif err ~= nil then
-              err = utils.flatten_table_to_string(err)
-              if err ~= "" then
-                vim.schedule_wrap(vim.notify)(
-                  err,
-                  vim.log.levels.WARN,
-                  vc_config.notify_opts
-                )
-              end
+              err = utils.flatten_table_to_string(err, "Unknown error.")
+              vim.schedule_wrap(vim.notify)(
+                err,
+                vim.log.levels.WARN,
+                vc_config.notify_opts
+              )
             end
           end
         )

lua/vectorcode/integrations/codecompanion/query_tool.lua

@@ -600,7 +600,7 @@ DO NOT MODIFY UNLESS INSTRUCTED BY THE USER, OR A PREVIOUS QUERY RETURNED NO RES
             vim.inspect(stderr)
           )
         )
-        stderr = utils.flatten_table_to_string(stderr)
+        stderr = utils.flatten_table_to_string(stderr, "Unknown error.")
         if string.find(stderr, "InvalidCollectionException") then
           if cmd.project_root then
             tools.chat:add_tool_output(

lua/vectorcode/integrations/codecompanion/vectorise_tool.lua

@@ -125,7 +125,7 @@ The value should be one of the following:
             vim.inspect(stderr)
           )
         )
-        stderr = utils.flatten_table_to_string(stderr)
+        stderr = utils.flatten_table_to_string(stderr, "Unknown error.")
         tools.chat:add_tool_output(
           self,
           string.format("**VectorCode `vectorise` Tool: %s", stderr)

lua/vectorcode/utils.lua

@@ -174,10 +174,12 @@ function M.is_directory(f)
 end
 
 ---@param t table|string|nil
+---@param fallback string?
 ---@return string
-M.flatten_table_to_string = function(t)
+M.flatten_table_to_string = function(t, fallback)
+  fallback = fallback or ""
   if t == nil then
-    return ""
+    return fallback
   end
   if type(t) == "string" then
     return t
@@ -193,7 +195,7 @@ M.flatten_table_to_string = function(t)
     :totable()
 
   if #flattened == 0 then
-    return "Unknown error occurred"
+    return fallback
   end
 
   return table.concat(flattened, "\n")