tests(db): skip tests when dependency's not met

Author: Davidyz

Makefile

@@ -1,9 +1,12 @@
-.PHONY: multitest
-
 EXTRA_LOCK_ARGS?=
-EXTRA_DEPS?=""
+EXTRA_DEPS?=
+
+LOADED_DOT_ENV=@if [ -f .env ] ; then source .env; fi;
+
 DEFAULT_GROUPS=--group dev --group lsp --group mcp --group debug $(EXTRA_LOCK_ARGS)
 
+.PHONY: multitest
+
 deps:
 	pdm lock $(DEFAULT_GROUPS) || pdm lock $(DEFAULT_GROUPS) --group legacy; \
 	pdm install

tests/database/test_chroma0.py

@@ -4,6 +4,21 @@
 
 import httpx
 import pytest
+
+try:
+    import chromadb
+
+    if not chromadb.__version__.startswith("0.6.3"):
+        pytest.skip(
+            f"Found chromadb {chromadb.__version__}. Skipping chroma0 tests.",
+            allow_module_level=True,
+        )
+except ModuleNotFoundError:
+    pytest.skip(
+        "ChromaDB 0.6.3 not found. Skipping choma0 tests.",
+        allow_module_level=True,
+    )
+
 from chromadb.api.types import QueryResult
 from chromadb.errors import InvalidCollectionException
 from tree_sitter import Point

tests/database/test_db_init.py

@@ -1,14 +1,42 @@
+import sys
+from unittest.mock import MagicMock, patch
+
 import pytest
 
 from vectorcode.cli_utils import Config
 from vectorcode.database import get_database_connector
-from vectorcode.database.chroma0 import ChromaDB0Connector
 
 
-def test_get_database_connector():
-    assert isinstance(
-        get_database_connector(Config(db_type="ChromaDB0")), ChromaDB0Connector
-    )
+@pytest.mark.parametrize(
+    "db_type, module_to_mock, class_name",
+    [
+        ("ChromaDB0", "vectorcode.database.chroma0", "ChromaDB0Connector"),
+        # To test a new connector, add a tuple here following the same pattern.
+        # e.g. ("NewDB", "vectorcode.database.newdb", "NewDBConnector"),
+    ],
+)
+def test_get_database_connector(db_type, module_to_mock, class_name):
+    """
+    Tests that get_database_connector can correctly return a connector
+    for a given db_type. This test is parameterized to be easily
+    extensible for new database connectors.
+    """
+    mock_connector_class = MagicMock()
+    mock_module = MagicMock()
+    setattr(mock_module, class_name, mock_connector_class)
+
+    # Use patch.dict to temporarily replace the module in sys.modules.
+    # This prevents the actual module from being imported, avoiding
+    # errors if its dependencies are not installed.
+    with patch.dict(sys.modules, {module_to_mock: mock_module}):
+        config = Config(db_type=db_type)
+        connector = get_database_connector(config)
+
+        # Verify that the create method was called on our mock class
+        mock_connector_class.create.assert_called_once_with(config)
+
+        # Verify that the returned connector is the one from our mock
+        assert connector == mock_connector_class.create.return_value
 
 
 def test_get_database_connector_invalid_type():