Skip to content

Commit d84fa81

Browse files
committed
fix(cli): Fixes db_url config retrieval
1 parent ff1c3da commit d84fa81

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

src/vectorcode/cli_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ async def import_from(cls, config_dict: dict[str, Any]) -> "Config":
135135
"embedding_dims", default_config.embedding_dims
136136
),
137137
"db_type": config_dict.get("db_type", default_config.db_type),
138-
"db_params": config_dict.get("db_url", default_config.db_params),
138+
"db_params": config_dict.get("db_params", default_config.db_params),
139139
"chunk_size": config_dict.get("chunk_size", default_config.chunk_size),
140140
"overlap_ratio": config_dict.get(
141141
"overlap_ratio", default_config.overlap_ratio

tests/test_cli_utils.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -56,25 +56,6 @@ async def test_config_import_from():
5656
assert config.reranker_params == {"reranker_param1": "reranker_value1"}
5757

5858

59-
@pytest.mark.asyncio
60-
async def test_config_import_from_invalid_path():
61-
config_dict: Dict[str, Any] = {"db_path": "/path/does/not/exist"}
62-
with pytest.raises(IOError):
63-
await Config.import_from(config_dict)
64-
65-
66-
@pytest.mark.asyncio
67-
async def test_config_import_from_db_path_is_file():
68-
with tempfile.TemporaryDirectory() as temp_dir:
69-
db_path = os.path.join(temp_dir, "test_db_file")
70-
with open(db_path, "w") as f:
71-
f.write("test")
72-
73-
config_dict: Dict[str, Any] = {"db_path": db_path}
74-
with pytest.raises(IOError):
75-
await Config.import_from(config_dict)
76-
77-
7859
@pytest.mark.asyncio
7960
async def test_config_merge_from():
8061
config1 = Config(db_params={"url": "http://host1:8001"}, n_result=5)

0 commit comments

Comments
 (0)