fix(cli): Replace InvalidCollectionException with NotFoundError

Author: Davidyz

src/vectorcode/mcp_main.py

@@ -6,7 +6,7 @@
 
 from chromadb.api import AsyncClientAPI
 from chromadb.api.models.AsyncCollection import AsyncCollection
-from chromadb.errors import InvalidCollectionException
+from chromadb.errors import NotFoundError
 
 try:  # pragma: nocover
     from mcp import ErrorData, McpError
@@ -116,7 +116,7 @@ async def mcp_server():
         default_client = await get_client(default_config)
         try:
             default_collection = await get_collection(default_client, default_config)
-        except InvalidCollectionException:
+        except NotFoundError:
             default_collection = None
 
     mcp.add_tool(

src/vectorcode/subcommands/drop.py

@@ -1,4 +1,4 @@
-from chromadb.errors import InvalidCollectionException
+from chromadb.errors import NotFoundError
 
 from vectorcode.cli_utils import Config
 from vectorcode.common import get_client, get_collection
@@ -12,6 +12,6 @@ async def drop(config: Config) -> int:
         await client.delete_collection(collection.name)
         print(f"Collection for {collection_path} has been deleted.")
         return 0
-    except (ValueError, InvalidCollectionException):
+    except (ValueError, NotFoundError):
         print(f"There's no existing collection for {config.project_root}")
         return 1

src/vectorcode/subcommands/query/__init__.py

@@ -5,7 +5,7 @@
 from chromadb import GetResult
 from chromadb.api.models.AsyncCollection import AsyncCollection
 from chromadb.api.types import IncludeEnum
-from chromadb.errors import InvalidCollectionException, InvalidDimensionException
+from chromadb.errors import InvalidDimensionException, NotFoundError
 
 from vectorcode.chunking import StringChunker
 from vectorcode.cli_utils import Config, QueryInclude, expand_globs, expand_path
@@ -151,7 +151,7 @@ async def query(configs: Config) -> int:
         collection = await get_collection(client, configs, False)
         if not verify_ef(collection, configs):
             return 1
-    except (ValueError, InvalidCollectionException):
+    except (ValueError, NotFoundError):
         print(
             f"There's no existing collection for {configs.project_root}",
             file=sys.stderr,

src/vectorcode/subcommands/update.py

@@ -5,7 +5,7 @@
 
 import tqdm
 from chromadb.api.types import IncludeEnum
-from chromadb.errors import InvalidCollectionException
+from chromadb.errors import NotFoundError
 
 from vectorcode.cli_utils import Config
 from vectorcode.common import get_client, get_collection, verify_ef
@@ -19,7 +19,7 @@ async def update(configs: Config) -> int:
     except IndexError:
         print("Failed to get/create the collection. Please check your config.")
         return 1
-    except (ValueError, InvalidCollectionException):
+    except (ValueError, NotFoundError):
         print(
             f"There's no existing collection for {configs.project_root}",
             file=sys.stderr,

tests/subcommands/query/test_query.py

@@ -4,7 +4,7 @@
 from chromadb import GetResult
 from chromadb.api.models.AsyncCollection import AsyncCollection
 from chromadb.api.types import IncludeEnum
-from chromadb.errors import InvalidCollectionException, InvalidDimensionException
+from chromadb.errors import InvalidDimensionException, NotFoundError
 
 from vectorcode.cli_utils import CliAction, Config, QueryInclude
 from vectorcode.subcommands.query import (
@@ -456,10 +456,7 @@ async def test_query_invalid_collection():
         patch("vectorcode.subcommands.query.get_collection") as mock_get_collection,
         patch("sys.stderr"),
     ):
-        # Make get_collection raise InvalidCollectionException
-        mock_get_collection.side_effect = InvalidCollectionException(
-            "Invalid collection"
-        )
+        mock_get_collection.side_effect = NotFoundError("Invalid collection")
 
         # Call the function
         result = await query(config)

tests/subcommands/test_update.py

@@ -2,7 +2,7 @@
 
 import pytest
 from chromadb.api.types import IncludeEnum
-from chromadb.errors import InvalidCollectionException
+from chromadb.errors import NotFoundError
 
 from vectorcode.cli_utils import Config
 from vectorcode.subcommands.update import update
@@ -113,7 +113,7 @@ async def test_update_invalid_collection_exception():
         patch("vectorcode.subcommands.update.get_client", return_value=mock_client),
         patch(
             "vectorcode.subcommands.update.get_collection",
-            side_effect=InvalidCollectionException,
+            side_effect=NotFoundError,
         ),
         patch("sys.stderr"),
     ):