Implement #respond_to_missing?

tylerhunt · tylerhunt · commit aa634fce66e8 · 2025-08-08T15:34:31.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 ## Unreleased
 
   * Avoid modifying frozen strings ([yuri-zubov][yuri-zubov])
+  * Define `#respond_to_missing?` on `Capybara::Node::Email`
+    ([tylerhunt][tylerhunt])
 
 ## 3.0.0
 
@@ -17,4 +19,5 @@
   * Corrects `inspect` of `Capybara::Node::Email`
   * Delegate all missing methods in `Capybara::Node::Email` to `base.email`
 
+[tylerhunt]: https://github.com/tylerhunt
 [yuri-zubov]: https://github.com/yuri-zubov
diff --git a/lib/capybara/email/driver.rb b/lib/capybara/email/driver.rb
@@ -68,18 +68,22 @@ def raw
 
   private
 
-  def method_missing(meth, *args, &block)
-    if email.respond_to?(meth)
+  def method_missing(method_name, *args, &block)
+    if email.respond_to?(method_name)
       if args.empty?
-        email.send(meth)
+        email.send(method_name)
       else
-        email.send(meth, args)
+        email.send(method_name, args)
       end
     else
       super
     end
   end
 
+  def respond_to_missing?(method_name, include_private = false)
+    email.respond_to?(method_name, include_private || super)
+  end
+
   def convert_to_html(text)
     "<html><body>#{convert_links(text)}</body></html>"
   end
diff --git a/lib/capybara/node/email.rb b/lib/capybara/node/email.rb
@@ -62,14 +62,16 @@ def save_and_open(file_name = nil)
 
   private
 
-  # Tries to send to `base` first.
-  # If an NotImplementedError is hit because some finders/matchers/etc. aren't implemented,
-  # fall back to treating the message body as a Capybara::Node::Simple
-  def method_missing(meth, *args, &block)
-    begin
-      base.send(meth, *args)
-    rescue NotImplementedError
-      body_as_simple_node.send(meth, *args)
-    end
+  # Tries to send to `base` first. If an NotImplementedError is hit because
+  # some finders/matchers/etc. aren't implemented, fall back to treating the
+  # message body as a Capybara::Node::Simple
+  def method_missing(method_name, *args, &block)
+    base.send(method_name, *args)
+  rescue NotImplementedError
+    body_as_simple_node.send(method_name, *args)
+  end
+
+  def respond_to_missing?(method_name, include_private = false)
+    base.respond_to?(method_name, include_private) || super
   end
 end
diff --git a/spec/node/email_spec.rb b/spec/node/email_spec.rb
@@ -37,6 +37,10 @@
     it 'delegates to the base' do
       expect(email.subject).to eq 'Test subject'
     end
+
+    it 'responds to :subject' do
+      expect(email).to respond_to(:subject)
+    end
   end
 
   describe '#to' do
@@ -47,6 +51,10 @@
     it 'delegates to the base' do
       expect(email.to).to include 'test@example.com'
     end
+
+    it 'responds to :to' do
+      expect(email).to respond_to(:to)
+    end
   end
 
   describe '#reply_to' do
@@ -57,6 +65,10 @@
     it 'delegates to the base' do
       expect(email.reply_to).to include 'test@example.com'
     end
+
+    it 'responds to :reply_to' do
+      expect(email).to respond_to(:reply_to)
+    end
   end
 
   describe '#from' do
@@ -67,6 +79,10 @@
     it 'delegates to the base' do
       expect(email.from).to include 'test@example.com'
     end
+
+    it 'responds to :from' do
+      expect(email).to respond_to(:from)
+    end
   end
 
   describe '#header' do
