Skip to content

Commit 98b57bf

Browse files
committed
Tried implementing union functions, but it was not worth the code bloat, permanent incompatibility with other collections, and confusing ambiguity between arguments. Better to just use insert and append on empty lists to create unions.
1 parent acd789d commit 98b57bf

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

Source/DFPSR/api/algorithmAPI_List.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -504,8 +504,6 @@ static inline intptr_t list_insert_unique_sorted_descending(
504504
return list_insert_unique_sorted<T>(targetList, element, [](const T &leftSide, const T &rightSide) -> bool { return leftSide >= rightSide; }, compareEqual);
505505
}
506506

507-
// TODO: Create a varargs union function, starting with nothing and adding unique elements from all lists before returning by value, so that duplicates in the first list are also reduced.
508-
509507
// Pre-conditions:
510508
// * All elements in targetList must be unique, or else they will remain duplicated.
511509
// * targetList and sourceList may not refer to the same list.

0 commit comments

Comments
 (0)