Merge pull request #181 from Daylily-Informatics/codex/bloom-legacy-removal-tapdb-actions

Remove Bloom legacy GUI/actions and adopt TapDB dispatcher execution

Author: iamh2o

bloom_lims/api/v1/__init__.py

@@ -11,7 +11,6 @@
 
 from fastapi import APIRouter
 
-from .actions import router as actions_router
 from .admin_auth import router as admin_auth_router
 from .async_tasks import router as async_tasks_router
 from .atlas_bridge import router as atlas_bridge_router
@@ -34,6 +33,7 @@
 from .templates import router as templates_router
 from .tracking import router as tracking_router
 from .user_api_tokens import router as user_api_tokens_router
+from .workflows import router as workflows_router
 from .worksets import router as worksets_router
 
 # Main v1 router
@@ -49,7 +49,6 @@
 router.include_router(batch_router)
 router.include_router(async_tasks_router)
 router.include_router(templates_router)
-router.include_router(actions_router)
 router.include_router(subjects_router)
 router.include_router(lineages_router)
 router.include_router(file_sets_router)
@@ -59,6 +58,7 @@
 router.include_router(object_creation_router)
 router.include_router(worksets_router)
 router.include_router(tracking_router)
+router.include_router(workflows_router)
 router.include_router(user_api_tokens_router)
 router.include_router(admin_auth_router)
 router.include_router(external_specimens_router)
@@ -83,7 +83,6 @@ async def api_v1_info():
             "batch": "/api/v1/batch",
             "tasks": "/api/v1/tasks",
             "templates": "/api/v1/templates",
-            "actions": "/api/v1/actions",
             "subjects": "/api/v1/subjects",
             "lineages": "/api/v1/lineages",
             "file_sets": "/api/v1/file-sets",
@@ -92,6 +91,7 @@ async def api_v1_info():
             "search_v2": "/api/v1/search/v2",
             "object_creation": "/api/v1/object-creation",
             "worksets": "/api/v1/worksets",
+            "workflows": "/api/v1/workflows",
             "user_tokens": "/api/v1/user-tokens",
             "admin_auth": "/api/v1/admin/groups",
             "external_specimens": "/api/v1/external/specimens",

bloom_lims/api/v1/actions.py

@@ -1,4 +1,4 @@
-"""Shared action execution service used by API and GUI routes."""
+"""TapDB-pattern GUI action execution service."""
 
 from __future__ import annotations
 
@@ -11,6 +11,7 @@
 from typing import Any
 
 from bloom_lims.core.exceptions import BloomValidationError
+from bloom_lims.core.tapdb_action_dispatcher import BloomTapDBActionDispatcher
 from bloom_lims.db import BLOOMdb3
 from bloom_lims.domain.base import BloomObj
 
@@ -193,6 +194,14 @@ def _resolve_action_definition(
     resolved = copy.deepcopy(action_data)
     if not isinstance(resolved.get("captured_data"), dict):
         resolved["captured_data"] = {}
+    if not resolved.get("action_template_uid"):
+        raise ActionExecutionError(
+            status_code=409,
+            detail=(
+                f"Action {action_key} is missing TapDB template metadata "
+                "(action_template_uid). Re-seed templates and recreate the object."
+            ),
+        )
     return resolved
 
 
@@ -323,14 +332,20 @@ def execute_action_for_instance(
         )
         action_ds["action_key"] = request_data.action_key
         action_ds["action_group"] = request_data.action_group
+        action_ds["_raw_action_key"] = request_data.action_key
 
         executor = _resolve_executor(instance, bdb)
         executor.set_actor_context(user_id=actor_user_id, email=actor_email)
-        result = executor.do_action(
-            request_data.euid,
-            action=request_data.action_key,
+        dispatcher = BloomTapDBActionDispatcher(executor)
+        result = dispatcher.execute_action(
+            session=bdb.session,
+            instance=instance,
             action_group=request_data.action_group,
+            action_key=request_data.action_key,
             action_ds=action_ds,
+            captured_data=request_data.captured_data,
+            create_action_record=True,
+            user=actor_email,
         )
 
         message = f"{request_data.action_key} performed for EUID {request_data.euid}"