[DbUp.Oracle] Script fail when comment at end

[Orkad]

Don't know if its only oracle related but in fact, if you try to run the following scripts :
create table FOO (myid INT NOT NULL); -- this comment will fail the script
create table FOO (myid INT NOT NULL); /* this comment will fail the script too */

the scripts will fail according to the oracle exception ORA-00900 invalid SQL statement.

DbUp consider the comment as SQL instruction in each cases.

[sungam3r]

What version do you use?

[Orkad]

4.3.0 (current latest)

[Orkad]

Actualy this simple test fail. Do you want a PR of that ?

[sungam3r]

Interesting. Perhaps this is due to \r\n absence at the end of script? It looks like a bug.

[Orkad]

Same problem with Environnement.NewLine at the end of script. I think the sql parser just split our script relative to the dialect delimiters. It will be interresting to remove comment from script before execution, or maybe detect if parsed text is a command.