Skip to content

Commit 5c5d8a7

Browse files
authored
Merge pull request #312 from De-Panther/enable_stencil
Enabled stencil buffer when creating the session XRWebGLLayer
2 parents d28ae12 + 280f18e commit 5c5d8a7

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

Packages/webxr/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased]
88

9+
### Changed
10+
- Enabled stencil buffer when creating the session XRWebGLLayer.
11+
912
## [0.18.0] - 2023-08-29
1013
### Added
1114
- Option to update active camera tag in WebXRCamera.

Packages/webxr/Runtime/Plugins/WebGL/webxr.jspre

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -849,18 +849,20 @@ setTimeout(function () {
849849

850850
XRManager.prototype.onSessionStarted = function (session) {
851851
var webXRSettings = this.gameModule.WebXR.Settings;
852-
var glLayer;
852+
var glLayerOptions = {
853+
alpha: true,
854+
antialias: true,
855+
depth: true,
856+
stencil: true
857+
};
853858
if (webXRSettings.UseFramebufferScaleFactor) {
854859
var scaleFactor = webXRSettings.FramebufferScaleFactor;
855860
if (webXRSettings.UseNativeResolution && XRWebGLLayer.getNativeFramebufferScaleFactor) {
856861
scaleFactor = XRWebGLLayer.getNativeFramebufferScaleFactor(session);
857862
}
858-
glLayer = new XRWebGLLayer(session, this.ctx, {
859-
framebufferScaleFactor: scaleFactor
860-
});
861-
} else {
862-
glLayer = new XRWebGLLayer(session, this.ctx);
863+
glLayerOptions.framebufferScaleFactor = scaleFactor;
863864
}
865+
var glLayer = new XRWebGLLayer(session, this.ctx, glLayerOptions);
864866
session.updateRenderState({ baseLayer: glLayer });
865867

866868
var refSpaceType = 'viewer';

0 commit comments

Comments
 (0)