Skip to content

Commit 3472890

Browse files
author
DeanLuus22021994
committed
fix: correct devcontainer.json service reference and document profiles
HIGH PRIORITY openai#4 - Docker Compose Profile Configuration Fixed Changes: - Fixed devcontainer.json: 'app' 'app-dev' service reference - Updated runServices to match docker-compose.yml services - Added Docker Compose Profiles section to README.md Profile Documentation: - dev (default): Development environment with hot reload - prod: Production deployment with resource limits - actors: Enables Dapr Placement service for actors/workflows VS Code Integration: - Tasks already configured for all profiles - DevContainer now correctly references app-dev service - All services (app-dev, redis, postgres, dapr-sidecar) properly defined Verification: - Current stack running with correct app-dev service - All 4 containers healthy and running - DevContainer configuration now matches docker-compose.yml
1 parent 88a8eb7 commit 3472890

File tree

2 files changed

+26
-3
lines changed

2 files changed

+26
-3
lines changed

.devcontainer/README.md

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,39 @@ This README provides an overview of the DevContainer environment. For detailed i
3131
### Using Docker Compose (Host Development)
3232

3333
```bash
34-
# Start full stack
34+
# Start development stack (default)
3535
docker-compose up -d
3636

37+
# Start with specific profile
38+
docker-compose --profile prod up -d # Production environment
39+
docker-compose --profile actors up -d # With Dapr Placement service
40+
3741
# Run validation tests from host
3842
powershell -ExecutionPolicy Bypass -File .\scripts\test-docker-stack.ps1 -Verbose
3943

4044
# View logs
4145
docker-compose logs -f
4246
```
4347

48+
### Docker Compose Profiles
49+
50+
The stack supports multiple profiles for different environments:
51+
52+
| Profile | Services | Use Case |
53+
|---------|----------|----------|
54+
| **dev** (default) | app-dev, redis, postgres, dapr-sidecar | Development with hot reload |
55+
| **prod** | app-prod, redis, postgres, dapr-sidecar | Production deployment |
56+
| **actors** | dapr-placement | Enable Dapr actors/workflows |
57+
58+
**VS Code Tasks Available**:
59+
60+
- `docker-compose: up dev` - Start development environment
61+
- `docker-compose: up prod` - Start production environment
62+
- `docker-compose: up actors` - Start with actors support
63+
- `docker-compose: down` - Stop all services
64+
65+
Press `Ctrl+Shift+P``Tasks: Run Task` to use these.
66+
4467
## Architecture
4568

4669
### Services

.devcontainer/devcontainer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"name": "OpenAI Agents Python SDK",
33
"dockerComposeFile": "../docker-compose.yml",
4-
"service": "app",
4+
"service": "app-dev",
55
"runServices": [
6-
"app",
6+
"app-dev",
77
"redis",
88
"postgres",
99
"dapr-sidecar"

0 commit comments

Comments
 (0)