Skip to content

Commit 5695d13

Browse files
authored
Merge pull request #271 from n-peugnet/estimate-progress
Fix progress and log output of estimate command
2 parents 5def67d + 9910944 commit 5695d13

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

estimate.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package main
22

33
import (
4+
"bytes"
45
"flag"
56
"fmt"
67
"log"
@@ -20,7 +21,7 @@ var majorVersionRegexp = regexp.MustCompile(`([/.])v([0-9]+)$`)
2021
func get(gopath, repodir, repo, rev string) error {
2122
done := make(chan struct{})
2223
defer close(done)
23-
go progressSize("go get", repodir, done)
24+
go progressSize("go get", gopath, done)
2425

2526
// As per https://groups.google.com/forum/#!topic/golang-nuts/N5apfenE4m4,
2627
// the arguments to “go get” are packages, not repositories. Hence, we
@@ -34,12 +35,18 @@ func get(gopath, repodir, repo, rev string) error {
3435
packages += "@" + rev
3536
}
3637
cmd := exec.Command("go", "get", "-t", packages)
38+
39+
out := bytes.Buffer{}
3740
cmd.Dir = repodir
38-
cmd.Stderr = os.Stderr
41+
cmd.Stderr = &out
3942
cmd.Env = append([]string{
4043
"GOPATH=" + gopath,
4144
}, passthroughEnv()...)
42-
return cmd.Run()
45+
err := cmd.Run()
46+
if err != nil {
47+
fmt.Fprint(os.Stderr, "\n", out.String())
48+
}
49+
return err
4350
}
4451

4552
func removeVendor(gopath string) (found bool, _ error) {

0 commit comments

Comments
 (0)