Skip to content

Commit f2d4ca9

Browse files
committed
Revert "Use DEP-14 branch names debian/latest and upstream/latest"
This reverts commit 79a2cc6. This was pushed and merged in a rush without Go team agreement or consensus, based on false premises where even the DEP it is based on does not have any mention of there being defaults preferences for these changes, where there's been recorded objections in general in the Debian project at large in the past, and where even existing practice (as analyzed by the same author) does not support these defaults being the majority in use. Ref: https://lists.debian.org/debian-devel/2024/08/msg00299.html
1 parent 911f0ad commit f2d4ca9

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

make.go

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ func runGitCommandIn(dir string, arg ...string) error {
416416
}
417417

418418
func createGitRepository(debsrc, gopkg, orig string, u *upstream,
419-
includeUpstreamHistory bool, allowUnknownHoster bool, debianBranch string, dep14 bool, pristineTar bool) (string, error) {
419+
includeUpstreamHistory bool, allowUnknownHoster bool, debianBranch string, pristineTar bool) (string, error) {
420420
wd, err := os.Getwd()
421421
if err != nil {
422422
return "", fmt.Errorf("get cwd: %w", err)
@@ -462,7 +462,7 @@ func createGitRepository(debsrc, gopkg, orig string, u *upstream,
462462

463463
// Preconfigure branches
464464

465-
branches := []string{debianBranch, "upstream/latest"}
465+
branches := []string{debianBranch, "upstream"}
466466
if pristineTar {
467467
branches = append(branches, "pristine-tar")
468468
}
@@ -496,9 +496,6 @@ func createGitRepository(debsrc, gopkg, orig string, u *upstream,
496496
// Import upstream orig tarball
497497

498498
arg := []string{"import-orig", "--no-interactive", "--debian-branch=" + debianBranch}
499-
if dep14 {
500-
arg = append(arg, "--upstream-branch=upstream/latest")
501-
}
502499
if pristineTar {
503500
arg = append(arg, "--pristine-tar")
504501
}
@@ -780,7 +777,7 @@ func execMake(args []string, usage func()) {
780777
fs.BoolVar(&dep14,
781778
"dep14",
782779
true,
783-
"Follow DEP-14 branch naming and use debian/latest (instead of master)\n"+
780+
"Follow DEP-14 branch naming and use debian/sid (instead of master)\n"+
784781
"as the default debian-branch.")
785782

786783
var pristineTar bool
@@ -890,7 +887,7 @@ func execMake(args []string, usage func()) {
890887
// Set the debian branch.
891888
debBranch := "master"
892889
if dep14 {
893-
debBranch = "debian/latest"
890+
debBranch = "debian/sid"
894891
}
895892

896893
switch strings.TrimSpace(wrapAndSort) {
@@ -981,7 +978,7 @@ func execMake(args []string, usage func()) {
981978

982979
debversion := u.version + "-1"
983980

984-
dir, err := createGitRepository(debsrc, gopkg, orig, u, includeUpstreamHistory, allowUnknownHoster, debBranch, dep14, pristineTar)
981+
dir, err := createGitRepository(debsrc, gopkg, orig, u, includeUpstreamHistory, allowUnknownHoster, debBranch, pristineTar)
985982
if err != nil {
986983
log.Fatalf("Could not create git repository: %v\n", err)
987984
}

template.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,8 +337,7 @@ func writeDebianGbpConf(dir string, dep14, pristineTar bool) error {
337337

338338
fmt.Fprintf(f, "[DEFAULT]\n")
339339
if dep14 {
340-
fmt.Fprintf(f, "debian-branch = debian/latest\n")
341-
fmt.Fprintf(f, "upstream-branch = upstream/latest\n")
340+
fmt.Fprintf(f, "debian-branch = debian/sid\n")
342341
fmt.Fprintf(f, "dist = DEP14\n")
343342
}
344343
if pristineTar {

0 commit comments

Comments
 (0)