Fails to download bazar repos

[gibmat]

This is probably a low-priority edge case, given the popularity of git. While working on packaging golang libraries for Debian, I came across launchpad.net/lpad, which is hosted in a bazar repository. dh-make-golang fails:

$ dh-make-golang make -allow_unknown_hoster launchpad.net/lpad
2021/11/25 00:00:11 Starting "dh-make-golang v0.5.0 linux/amd64"
2021/11/25 00:00:11 WARNING: Using "launchpad" as canonical hostname for "launchpad.net". If that is not okay, please file a bug against dh-make-golang.
2021/11/25 00:00:11 Downloading "launchpad.net/lpad/..."
go get: 0.00 KiB# cd .; bzr branch https://launchpad.net/lpad /tmp/dh-make-golang670780065/src/launchpad.net/lpad
brz: ERROR: Parent of "/tmp/dh-make-golang670780065/src/launchpad.net/lpad" does not exist.
2021/11/25 00:00:16 Could not create a tarball of the upstream source: go get: exit status 3

It looks like bzr branch won't create a parent directory if it's missing, so dh-make-golang (or maybe go get?) should first ensure the desired parent directory exists, then run bzr branch.

[zhsj]

hmm, is "launchpad.net/lpad" still a thing? It hasn't been updated for 8 years.

[gibmat]

That was basically my observation as well. It's used by github.com/canonical/candid; for the time being I've patched it out of my Debian packaging work, so this isn't blocking me. But, I did want to at least file a report that dh-make-golang has a problem with bazar repos.