STUPID serialization bug finally fixed

Author: Zweronz

Source/AssetRipper.Assets/Collections/AssetCollection.cs

@@ -223,6 +223,11 @@ public T GetAsset<T>(int fileIndex, long pathID) where T : IUnityObjectBase
 
 	public bool TryGetAsset(int fileIndex, long pathID, [NotNullWhen(true)] out IUnityObjectBase? asset)
 	{
+		if (fileIndex < 0 || fileIndex > Dependencies.Count - 1)
+		{
+			asset = null;
+			return false;
+		}
 		AssetCollection? file = Dependencies[fileIndex];
 		if (file is not null)
 		{

Source/AssetRipper.Import/Structure/Assembly/Serializable/SerializableField.cs

@@ -16,8 +16,24 @@ namespace AssetRipper.Import.Structure.Assembly.Serializable
 	[DebuggerDisplay($"{{{nameof(GetDebuggerDisplay)}(),nq}}")]
 	public record struct SerializableField(ulong PValue, object CValue)
 	{
+		private static List<PrimitiveType> supportedUnity4Types = new List<PrimitiveType>
+		{
+			PrimitiveType.Bool,
+			PrimitiveType.Byte,
+			PrimitiveType.Int,
+			PrimitiveType.Single,
+			PrimitiveType.Double,
+			PrimitiveType.String,
+			PrimitiveType.Complex
+		};
+
 		public void Read(ref EndianSpanReader reader, UnityVersion version, TransferInstructionFlags flags, int depth, in SerializableType.Field etalon)
 		{
+			if (version.IsLess(5, 0, 0) && !supportedUnity4Types.Contains(etalon.Type.Type))
+			{
+				return;
+			}
+
 			switch (etalon.Type.Type)
 			{
 				case PrimitiveType.Bool:
@@ -384,6 +400,11 @@ public void Write(AssetWriter writer, in SerializableType.Field etalon)
 
 		public YamlNode ExportYaml(IExportContainer container, in SerializableType.Field etalon)
 		{
+			if (container.Version.IsLess(5, 0, 0) && !supportedUnity4Types.Contains(etalon.Type.Type))
+			{
+				return null;
+			}
+
 			if (etalon.IsArray)
 			{
 				if (etalon.Type.Type == PrimitiveType.Complex)
@@ -502,6 +523,11 @@ public YamlNode ExportYaml(IExportContainer container, in SerializableType.Field
 
 		internal void CopyValues(SerializableField source, UnityVersion version, int depth, in SerializableType.Field etalon, PPtrConverter converter)
 		{
+			if (version.IsLess(5, 0, 0) && !supportedUnity4Types.Contains(etalon.Type.Type))
+			{
+				return;
+			}
+
 			if (etalon.IsArray)
 			{
 				PValue = default;

Source/AssetRipper.Import/Structure/Assembly/Serializable/SerializableStructure.cs

@@ -56,7 +56,11 @@ public YamlMappingNode ExportYaml(IExportContainer container)
 				SerializableType.Field etalon = Type.GetField(i);
 				if (IsAvailable(etalon))
 				{
-					node.Add(etalon.Name, Fields[i].ExportYaml(container, etalon));
+					YamlNode yamlNode = Fields[i].ExportYaml(container, etalon);
+					if (yamlNode != null)
+					{
+						node.Add(etalon.Name, yamlNode);
+					}
 				}
 			}
 			return node;
@@ -107,14 +111,14 @@ public bool TryRead(ref EndianSpanReader reader, UnityVersion version, TransferI
 			catch (Exception ex)
 			{
 				LogMonoBehaviorReadException(this, ex);
-				WriteDebug(ref reader);
-				return false;
+				//WriteDebug(ref reader);
+				//return false;
 			}
 			if (reader.Position != reader.Length)
 			{
 				LogMonoBehaviourMismatch(this, reader.Position, reader.Length);
-				WriteDebug(ref reader);
-				return false;
+				//WriteDebug(ref reader);
+				//return false;
 			}
 			return true;
 		}