Skip to content

Commit 4d906a4

Browse files
fix: Properly cleanup multilingual glossaries in tests
1 parent 882754d commit 4d906a4

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

tests/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ def translator_with_random_auth_key_and_proxy(server):
206206

207207

208208
@pytest.fixture
209-
def cleanup_matching_glossaries(translator):
209+
def cleanup_matching_glossaries(deepl_client):
210210
"""
211211
Fixture function to remove all glossaries from the server matching the
212212
given predicate. Can be used, for example, to remove all glossaries with a
@@ -221,11 +221,11 @@ def test_example(cleanup_matching_glossaries):
221221
"""
222222

223223
def do_cleanup(predicate: Callable[[deepl.GlossaryInfo], bool]):
224-
glossaries = translator.list_glossaries()
224+
glossaries = deepl_client.list_multilingual_glossaries()
225225
for glossary in glossaries:
226226
if predicate(glossary):
227227
try:
228-
translator.delete_glossary(glossary)
228+
deepl_client.delete_multilingual_glossary(glossary)
229229
except deepl.DeepLException:
230230
pass
231231

tests/test_multilingual_glossary.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,7 @@ def test_glossary_name_update(
140140
with pytest.raises(ValueError):
141141
deepl_client.update_multilingual_glossary_name(glossary, "")
142142
finally:
143-
cleanup_matching_glossaries(
144-
lambda glossary: glossary.name == glossary_name
145-
)
143+
cleanup_matching_glossaries(lambda glossary: glossary.name == new_name)
146144

147145

148146
def test_glossary_dictionary_replace(

0 commit comments

Comments
 (0)