Skip to content

Commit abcc0d3

Browse files
fix: also send options in API requests even if they are default values
1 parent 4665afe commit abcc0d3

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313
For Python 3.6 tests `pytest` needs to be added manually.
1414
* Remove unused `tox` dependency.
1515
* Update `coverage` dependency.
16+
* Also send options in API requests even if they are default values.
1617

1718

1819
## [1.11.0] - 2022-09-26

deepl/translator.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ def _check_language_and_formality(
610610
self,
611611
source_lang: Union[str, Language, None],
612612
target_lang: Union[str, Language],
613-
formality: Union[str, Formality],
613+
formality: Union[str, Formality, None],
614614
glossary: Union[str, GlossaryInfo, None] = None,
615615
) -> dict:
616616
# target_lang and source_lang are case insensitive
@@ -636,7 +636,7 @@ def _check_language_and_formality(
636636
request_data = {"target_lang": target_lang}
637637
if source_lang is not None:
638638
request_data["source_lang"] = source_lang
639-
if str(formality).lower() != str(Formality.DEFAULT):
639+
if formality is not None:
640640
request_data["formality"] = str(formality).lower()
641641
if isinstance(glossary, GlossaryInfo):
642642
request_data["glossary_id"] = glossary.glossary_id
@@ -687,12 +687,12 @@ def translate_text(
687687
*,
688688
source_lang: Union[str, Language, None] = None,
689689
target_lang: Union[str, Language],
690-
split_sentences: Union[str, SplitSentences] = SplitSentences.ALL,
691-
preserve_formatting: bool = False,
692-
formality: Union[str, Formality] = Formality.DEFAULT,
690+
split_sentences: Union[str, SplitSentences, None] = None,
691+
preserve_formatting: Optional[bool] = None,
692+
formality: Union[str, Formality, None] = None,
693693
glossary: Union[str, GlossaryInfo, None] = None,
694694
tag_handling: Optional[str] = None,
695-
outline_detection: bool = True,
695+
outline_detection: Optional[bool] = None,
696696
non_splitting_tags: Union[str, List[str], None] = None,
697697
splitting_tags: Union[str, List[str], None] = None,
698698
ignore_tags: Union[str, List[str], None] = None,
@@ -754,14 +754,18 @@ def translate_text(
754754
)
755755
request_data["text"] = text
756756

757-
if str(split_sentences) != str(SplitSentences.DEFAULT):
757+
if split_sentences is not None:
758758
request_data["split_sentences"] = str(split_sentences)
759-
if preserve_formatting:
760-
request_data["preserve_formatting"] = "1"
759+
if preserve_formatting is not None:
760+
request_data["preserve_formatting"] = (
761+
"1" if preserve_formatting else "0"
762+
)
761763
if tag_handling is not None:
762764
request_data["tag_handling"] = tag_handling
763-
if not outline_detection:
764-
request_data["outline_detection"] = "0"
765+
if outline_detection is not None:
766+
request_data["outline_detection"] = (
767+
"1" if outline_detection else "0"
768+
)
765769

766770
def join_tags(tag_argument: Union[str, Iterable[str]]) -> str:
767771
return (
@@ -952,7 +956,7 @@ def translate_document_upload(
952956
*,
953957
source_lang: Optional[str] = None,
954958
target_lang: str,
955-
formality: Union[str, Formality] = Formality.DEFAULT,
959+
formality: Union[str, Formality, None] = None,
956960
glossary: Union[str, GlossaryInfo, None] = None,
957961
filename: Optional[str] = None,
958962
) -> DocumentHandle:

0 commit comments

Comments
 (0)