Upgrade Go to 1.25.3 and refresh dependencies #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jai-deepsource
commented
Dec 16, 2025
jai-deepsource
commented
- Bump Go version in CI, Makefile, and go.mod
- Replace deprecated ioutil and strings.Title usages
- Update GitHub Actions and all module dependencies
jai-deepsource
force-pushed
the
improvements
branch
3 times, most recently
from
dc44d0d to
c875f5a
Compare
- Bump Go version in CI, Makefile, and go.mod - Replace deprecated ioutil and strings.Title usages - Update GitHub Actions and all module dependencies Signed-off-by: Jai Pradeesh <[email protected]>
jai-deepsource
force-pushed
the
improvements
branch
from
c875f5a to
a299363
Compare
Signed-off-by: Sourya Vatsyayan <[email protected]>
Signed-off-by: Sourya Vatsyayan <[email protected]>
Signed-off-by: Sourya Vatsyayan <[email protected]>
- wait for mock HTTP server to be ready before running tests - prevents flaky test failures due to connection refused errors
- fixes RVV-B0012 DeepSource issues for unused parameters
- increases wait iterations from 50 to 200 for more reliability
- Add authentication section with login examples (browser, token, enterprise) - Document OIDC authentication for GitHub Actions - Expand command reference with subcommand details - Add auth, config, issues, and repo subcommand descriptions
- login: extract getConfig, confirmFromUser, selectFromOptions, getSingleLineInput - logout: extract getConfig, confirmFromUser - refresh: extract getConfig, newDeepsource - status: extract getConfig Enables mocking of dependencies in unit tests
Enables mocking of survey.AskOne in unit tests for prompt utilities
- auth/login: test command creation, interactive login flows, re-auth prompts - auth/logout: test config errors, not-logged-in state, user cancellation - auth/refresh: test config errors, client creation, token refresh - auth/status: test config errors, not-logged-in, valid/expired tokens - config/generate: test config generation with analyzers, transformers, patterns - report: test sanitize, validateKey, git commit detection, makeQuery - utils/prompt: test ConfirmFromUser, SelectFromOptions, GetSingleLineInput - utils/cmd_validator: test ExactArgs, MaxNArgs, NoArgs validators
- Use underscore prefix for unused cobra command parameters - Refactor logout to use struct fields instead of package-level vars - Fix mutex double-unlock issues in status_test.go - Replace deprecated ioutil.ReadFile with os.ReadFile - Convert value receivers to pointer receivers where appropriate - Extract setupGitRepo helper and use table-driven tests - Improve error handling with io.ReadAll and json.NewEncoder - Add configFilePermissions constant and clean up config.go - Use DialTimeout for server readiness checks - Fix test loop variable capture issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.