fix: improve parsing output of cppcheck (#4)

swarnim-deepsource · web-flow · commit 8289f8f467df · 2023-06-27T17:35:17.000+05:30
* fix: improve parsing output of cppcheck

cppcheck can produce malformed output which needs to be explicitly handled

* fix: set default to C++20

* revert: default to `c11`
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 /target
 /cppcheck_result.json
-/cppcheck_error.xml
+/cppcheck_error.xml
+analysis_config.json
diff --git a/analysis_config.json b/analysis_config.json
diff --git a/src/cppcheck.rs b/src/cppcheck.rs
@@ -25,7 +25,8 @@ pub struct Error {
     #[serde(rename = "@cwe")]
     pub cwe: Option<String>,
     pub location: Option<Vec<Location>>,
-    pub symbol: Option<String>,
+    #[serde(default)]
+    pub symbol: Vec<String>,
 }
 
 #[derive(Serialize, Deserialize, Debug)]
diff --git a/src/main.rs b/src/main.rs
@@ -109,7 +109,11 @@ fn _main() -> Result<(), Box<dyn Error>> {
                     format!(
                         "{} {}",
                         error.id,
-                        error.symbol.unwrap_or_else(|| "".to_string())
+                        error
+                            .symbol
+                            .get(0)
+                            .map(String::as_str)
+                            .unwrap_or_else(|| "")
                     )
                 } else {
                     error.msg

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@ pub struct Error {`
`25`	`25`	`#[serde(rename = "@cwe")]`
`26`	`26`	`pub cwe: Option<String>,`
`27`	`27`	`pub location: Option<Vec<Location>>,`
`28`		`- pub symbol: Option<String>,`
	`28`	`+ #[serde(default)]`
	`29`	`+ pub symbol: Vec<String>,`
`29`	`30`	`}`
`30`	`31`
`31`	`32`	`#[derive(Serialize, Deserialize, Debug)]`