Skip to content

Commit 225b23a

Browse files
Apply suggestions from code review
Co-authored-by: Lio李歐 <[email protected]>
1 parent 99859c2 commit 225b23a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/faq.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ secrets:
147147

148148
### "invalid healthcheck: ingress ports require an HTTP healthcheck on `localhost`.
149149

150-
- This message is displayed when `defang compose up` tries to deploy a service with an "ingress" port, if the service does not have a `healthcheck` which mentions `localhost`. Defang routes a load balancer to your service's ingress ports, and the loadbalancer needs to be able to check the health of the service. Two solve this issue, ask yourself these two questions:
150+
- This message is displayed when `defang compose up` tries to deploy a service with an "ingress" port, if the service does not have a `healthcheck` which mentions `localhost`. Defang routes a load balancer to your service's ingress ports, and the loadbalancer needs to be able to check the health of the service. To solve this issue, ask yourself these two questions:
151151

152152
1. Should my service be public? It's common to declare your container's ports using the Compose file "shorthand" syntax (`1234:1234`). This syntax can be understood as `[HOST:]CONTAINER`. If your service is not intended to be public, you do not need to declare a HOST port. For example:
153153

@@ -166,7 +166,7 @@ secrets:
166166
test: ["CMD", "curl", "-f", "http://localhost:1234/health"]
167167
```
168168

169-
This healthcheck is not valid:
169+
This healthcheck is not valid for `ingress` ports:
170170

171171
```yaml
172172
healthcheck:

0 commit comments

Comments
 (0)