Skip to content

Commit 936ddf0

Browse files
authored
Apply suggestions from code review
1 parent 288a6f1 commit 936ddf0

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

docs/providers/gcp.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,27 @@ sidebar_position: 3000
77
# Google Cloud Platform (GCP)
88

99
:::info
10-
The Defang GCP provider is available for Public Preview as of December 2024. This page will be updated when it is GA.
10+
The Defang GCP provider is available for Public Preview as of December 2024.
1111
:::
1212

1313
Defang enables you to effortlessly create and manage full, scalable applications with GCP. It is designed to simplify deploying your services to the cloud. As one of the leading cloud providers globally, GCP offers powerful tools and resources, and with Defang, you can bypass the complexities and challenges of the GCP platform. Let Defang handle the heavy lifting so you can focus on what matters most to you!
1414

1515
## Getting Started
1616

17-
After signing in to your GCP account, select an existing project or [create a new project](https://developers.google.com/workspace/guides/create-project), make sure [billing is enabled](https://cloud.google.com/billing/docs/how-to/modify-project) and note down the project ID and set it as environment variable `GCP_PROJECT_ID`.
17+
After signing in to your GCP account, select an existing project or [create a new project](https://developers.google.com/workspace/guides/create-project), make sure [billing is enabled](https://cloud.google.com/billing/docs/how-to/modify-project), and note down the project ID and set it as environment variable `GCP_PROJECT_ID`.
1818

1919
```bash
2020
export GCP_PROJECT_ID=<your-project-id>
2121
```
2222

23-
Next step is to [authenticate your local environment with GCP](https://cloud.google.com/docs/authentication), our preferred method is to setup [Application Default Credentials](https://cloud.google.com/docs/authentication/provide-credentials-adc) with the google cloud CLI. Once the [google cloud CLI is installed](https://cloud.google.com/sdk/docs/install), run the following command to authenticate:
23+
Next step is to [authenticate your local environment with GCP](https://cloud.google.com/docs/authentication). Our preferred method is to setup [Application Default Credentials](https://cloud.google.com/docs/authentication/provide-credentials-adc) with the Google Cloud CLI. Once the [Google Cloud CLI is installed](https://cloud.google.com/sdk/docs/install), run the following command to authenticate:
2424

2525
```bash
2626
gcloud init
2727
gcloud auth application-default login
2828
```
2929

30-
The Defang CLI will automatically check if they are set before running. Once you are ready to go, add the `--provider=gcp` to your command to tell the Defang CLI to use the GCP provider.
30+
The Defang CLI will automatically check if `GCP_PROJECT_ID` environment variable is set and correctly authenticated with GCP before running. Once you are ready to go, add the `--provider=gcp` to your command to tell the Defang CLI to use the GCP provider.
3131

3232
```bash
3333
$ defang up --provider=gcp
@@ -41,15 +41,15 @@ The Defang BYOC GCP Provider will use the location specified in the `GCP_LOCATIO
4141

4242
## Architecture
4343

44-
Defang uses GCP cloud run to build, deploy and run your services. The following describes the current state of Defang's support for GCP, the specific resources that Defang uses, and the roadmap for future support.
44+
Defang uses GCP cloud run to build, deploy, and run your services. The following describes the current state of Defang's support for GCP, the specific resources that Defang uses, and the roadmap for future support.
4545

4646
### Deployment
4747

48-
To deploy your services, the Defang CLI will setup some basic resources needed, including enabled required APIs in the project, create service accounts used to build and deploy your service with required permissions, and a [Google Cloud Storage](https://cloud.google.com/storage) bucket where Defang CLI packages your code and uploads it to. The CLI then deploys a Cloud Run Job that uses Pulumi to build your container image and run your services.
48+
To deploy your services, the Defang CLI sets up some basic resources needed, including enabling required APIs in the project, creating service accounts used to build and deploy your service with the required permissions, and creating a [Google Cloud Storage](https://cloud.google.com/storage) bucket where the Defang CLI uploads your source code to. The CLI then deploys a GCP Cloud Run Job that uses Pulumi to build your container image and run your services.
4949

5050
### Runtime
5151

52-
The Provider build and deploy your services using the [Google Cloud Run](https://cloud.google.com/run) jobs, and runs your workloads using the [Google Cloud Run](https://cloud.google.com/run) service.
52+
The Provider builds and deploys your services using [Google Cloud Run](https://cloud.google.com/run) jobs, and runs your workloads using the [Google Cloud Run](https://cloud.google.com/run) service.
5353

5454
### Secrets
5555

docs/tutorials/deploy-to-gcp.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ sidebar_position: 11
66

77
# Deploying to Google Cloud Platform (GCP) With Defang
88

9-
This tutorial will show you how to deploy your services to your own AWS account using Defang.
9+
This tutorial will show you how to deploy your services to your own GCP project using Defang.
1010

1111
## Pre-requisites
1212
* [A Dockerfile in your project](https://docs.docker.com/get-started/docker-concepts/building-images/writing-a-dockerfile/)
@@ -23,7 +23,7 @@ $ cd path/to/your/project
2323

2424
## Step 2 - Authenticate Defang to use your GCP Account
2525

26-
After signing up for your GCP account, select an existing project or [create a new project](https://developers.google.com/workspace/guides/create-project). Make sure [billing is enabled](https://cloud.google.com/billing/docs/how-to/modify-project). Then, note down the project ID and set it as environment variable `GCP_PROJECT_ID`.
26+
After signing in for your GCP account, select an existing project or [create a new project](https://developers.google.com/workspace/guides/create-project). Make sure [billing is enabled](https://cloud.google.com/billing/docs/how-to/modify-project). Then, note down the project ID and set it as environment variable `GCP_PROJECT_ID`.
2727

2828
## Step 3 - Deploy
2929

@@ -37,7 +37,7 @@ $ defang up --provider=gcp
3737

3838
## Step 4 - Inspect your deployment
3939

40-
Defang will provision resources in your GCP account and deploy your services. You can inspect the resources created in your GCP dashboard.
40+
Defang will provision resources in your GCP account and deploy your services. You can inspect the resources created in your [GCP Dashboard](https://console.cloud.google.com/).
4141

4242
***
4343

0 commit comments

Comments
 (0)