To me, this makes sense. Looks like the main diff is that it keeps the samples build script, is that right @jordanstephens ? That should solve the issue we had.

To me, this makes sense. Looks like the main diff is that it keeps the samples build script, is that right @jordanstephens ? That should solve the issue we had.

Yep that's exactly right. The corp website requests samples from the docs website, so this PR removes the presentation of the samples in the docs, but continues building them so the corp website can fetch them. See https://github.com/DefangLabs/defang-mvp/blob/37d84acb9fbdd03822051058084d7c7d665a7e8c/website/src/modules/samples/lib/fetch-samples/fetch-samples.ts#L16

In the future, we should cut the docs website out of the loop, but this will get things moving for now.

To me, this makes sense. Looks like the main diff is that it keeps the samples build script, is that right @jordanstephens ? That should solve the issue we had.

Yep that's exactly right. The corp website requests samples from the docs website, so this PR removes the presentation of the samples in the docs, but continues building them so the corp website can fetch them. See https://github.com/DefangLabs/defang-mvp/blob/37d84acb9fbdd03822051058084d7c7d665a7e8c/website/src/modules/samples/lib/fetch-samples/fetch-samples.ts#L16

In the future, we should cut the docs website out of the loop, but this will get things moving for now.

Agreed. We had talked about it previously, but ended up deciding that it would be simpler at that time to just roll with it. I think samples.defang.io/samples.json or something would make more sense.

To me, this makes sense. Looks like the main diff is that it keeps the samples build script, is that right @jordanstephens ? That should solve the issue we had.

Yep that's exactly right. The corp website requests samples from the docs website, so this PR removes the presentation of the samples in the docs, but continues building them so the corp website can fetch them. See DefangLabs/defang-mvp@37d84ac/website/src/modules/samples/lib/fetch-samples/fetch-samples.ts#L16
In the future, we should cut the docs website out of the loop, but this will get things moving for now.

Agreed. We had talked about it previously, but ended up deciding that it would be simpler at that time to just roll with it. I think samples.defang.io/samples.json or something would make more sense.

Sure, we may be able to set up a github pages site for the samples repo to host a json file that we build in an action on merge.

To me, this makes sense. Looks like the main diff is that it keeps the samples build script, is that right @jordanstephens ? That should solve the issue we had.

Yep that's exactly right. The corp website requests samples from the docs website, so this PR removes the presentation of the samples in the docs, but continues building them so the corp website can fetch them. See DefangLabs/defang-mvp@37d84ac/website/src/modules/samples/lib/fetch-samples/fetch-samples.ts#L16
In the future, we should cut the docs website out of the loop, but this will get things moving for now.

Agreed. We had talked about it previously, but ended up deciding that it would be simpler at that time to just roll with it. I think samples.defang.io/samples.json or something would make more sense.

Sure, we may be able to set up a github pages site for the samples repo to host a json file that we build in an action on merge.

Exactly. I think that makes a lot more sense. I'll add an issue for it.