chore: add test case for railpack command fixup (#1392)

* chore: add test case for railpack command fixup

* fixup railpack commands to compensate for bash -c entrypoint

* golden file does not include fixup

---------

Co-authored-by: Jordan Stephens <[email protected]>

Author: lionello

src/pkg/cli/compose/fixup.go

@@ -9,6 +9,7 @@ import (
 	"strconv"
 	"strings"
 
+	"al.essio.dev/pkg/shellescape"
 	"github.com/DefangLabs/defang/src/pkg/cli/client"
 	"github.com/DefangLabs/defang/src/pkg/term"
 	defangv1 "github.com/DefangLabs/defang/src/protos/io/defang/v1"
@@ -95,6 +96,20 @@ func FixupServices(ctx context.Context, provider client.Provider, project *compo
 					}
 					// hint to CD that we want to use Railpack
 					svccfg.Build.Dockerfile = RAILPACK
+
+					// railpack generates images with `Entrypoint: "bash -c"`, and
+					// compose-go normalizes string commands into arrays, for example:
+					// `command: npm start` -> `command: [ "npm", "start" ]`. As a
+					// result, the command which ultimately gets run is
+					// `bash -c npm start`. When this gets run, `bash` will ignore
+					// `start` and `npm` will get run in a subprocess--only printing
+					// the help text. As it is common for users to type their service
+					// command as a string, this cleanup step will help ensure the
+					// command is run as intended by replacing `command: [ "npm", "start" ]`
+					// with `command: [ "npm start" ]`.
+					if len(svccfg.Command) > 1 {
+						svccfg.Command = []string{shellescape.QuoteCommand(svccfg.Command)}
+					}
 				}
 			}
 

src/testdata/railpack/compose.yaml

@@ -1,10 +1,13 @@
 services:
   railpack-short:
     build: .
+    command: npm start
   railpack-long:
     build:
       context: .
+    command: exec node index.js
   railpackwithdockerfile:
     build:
       context: .
       dockerfile: Dockerfile
+    command: something "with space"

src/testdata/railpack/compose.yaml.fixup

@@ -4,7 +4,9 @@
       "context": ".",
       "dockerfile": "*Railpack"
     },
-    "command": null,
+    "command": [
+      "exec node index.js"
+    ],
     "entrypoint": null,
     "networks": {
       "default": null
@@ -15,7 +17,9 @@
       "context": ".",
       "dockerfile": "*Railpack"
     },
-    "command": null,
+    "command": [
+      "npm start"
+    ],
     "entrypoint": null,
     "networks": {
       "default": null
@@ -26,7 +30,9 @@
       "context": ".",
       "dockerfile": "*Railpack"
     },
-    "command": null,
+    "command": [
+      "something 'with space'"
+    ],
     "entrypoint": null,
     "networks": {
       "default": null

src/testdata/railpack/compose.yaml.golden

@@ -4,18 +4,28 @@ services:
     build:
       context: .
       dockerfile: Dockerfile
+    command:
+      - exec
+      - node
+      - index.js
     networks:
       default: null
   railpack-short:
     build:
       context: .
       dockerfile: Dockerfile
+    command:
+      - npm
+      - start
     networks:
       default: null
   railpackwithdockerfile:
     build:
       context: .
       dockerfile: Dockerfile
+    command:
+      - something
+      - with space
     networks:
       default: null
 networks: