Merge pull request #376 from defang-io/eric-delete-config-refactor

Implement use of DeleteSecrets cli call.

Author: lionello

src/cmd/cli/command/commands.go

@@ -46,8 +46,8 @@ func prettyError(err error) error {
 	// To avoid printing the internal gRPC error code
 	var cerr *connect.Error
 	if errors.As(err, &cerr) {
-		term.Debug(" - Server error:", err)
-		err = errors.Unwrap(err)
+		term.Debug(" - Server error:", cerr)
+		err = errors.Unwrap(cerr)
 	}
 	return err
 

src/pkg/cli/client/grpc.go

@@ -125,10 +125,8 @@ func (g GrpcClient) PutConfig(ctx context.Context, req *defangv1.SecretValue) er
 func (g GrpcClient) DeleteConfig(ctx context.Context, req *defangv1.Secrets) error {
 	// _, err := g.client.DeleteSecrets(ctx, &connect.Request[v1.Secrets]{Msg: req}); TODO: implement this in the server
 	var errs []error
-	for _, name := range req.Names {
-		_, err := g.client.PutSecret(ctx, &connect.Request[defangv1.SecretValue]{Msg: &defangv1.SecretValue{Name: name}})
-		errs = append(errs, err)
-	}
+	_, err := g.client.DeleteSecrets(ctx, &connect.Request[defangv1.Secrets]{Msg: &defangv1.Secrets{Names: req.Names}})
+	errs = append(errs, err)
 	return errors.Join(errs...)
 }