Skip to content

Commit 95f135a

Browse files
committed
Remvoe warning about BYOD for playground
1 parent 549f06c commit 95f135a

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

src/cmd/cli/command/commands.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,7 @@ func printEndpoints(serviceInfos []*defangv1.ServiceInfo) {
742742
if serviceInfo.ZoneId != "" {
743743
fmt.Println(" -", "https://"+serviceInfo.Service.Domainname)
744744
} else {
745-
fmt.Println(" -", "https://"+serviceInfo.Service.Domainname+" (after ACME cert activation)")
745+
fmt.Println(" -", "https://"+serviceInfo.Service.Domainname+" (after `defang cert generate` to get a Let's Encrypt certificate)")
746746
}
747747
}
748748
}

src/pkg/cli/client/grpc.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
"github.com/bufbuild/connect-go"
1616
compose "github.com/compose-spec/compose-go/v2/types"
1717
"github.com/defang-io/defang/src/pkg/auth"
18-
"github.com/defang-io/defang/src/pkg/term"
1918
"github.com/defang-io/defang/src/pkg/types"
2019
defangv1 "github.com/defang-io/defang/src/protos/io/defang/v1"
2120
"github.com/defang-io/defang/src/protos/io/defang/v1/defangv1connect"
@@ -87,12 +86,6 @@ func (g GrpcClient) Update(ctx context.Context, req *defangv1.Service) (*defangv
8786
}
8887

8988
func (g GrpcClient) Deploy(ctx context.Context, req *defangv1.DeployRequest) (*defangv1.DeployResponse, error) {
90-
// TODO: remove this when playground supports BYOD
91-
for _, service := range req.Services {
92-
if service.Domainname != "" {
93-
term.Warnf("Defang provider does not support the domainname field for now, service: %v, domain: %v", service.Name, service.Domainname)
94-
}
95-
}
9689
return getMsg(g.client.Deploy(ctx, &connect.Request[defangv1.DeployRequest]{Msg: req}))
9790
}
9891

0 commit comments

Comments
 (0)