Skip to content

Commit c87c90b

Browse files
nullfunclionello
andauthored
show browser opening errors (#1457)
* show browser opening errors * Apply suggestions from code review --------- Co-authored-by: Lio李歐 <[email protected]>
1 parent 3f24ead commit c87c90b

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/pkg/auth/auth.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package auth
22

33
import (
44
"context"
5+
"fmt"
56
"html/template"
67
"log/slog"
78
"net/http"
@@ -190,7 +191,10 @@ func StartAuthCodeFlow(ctx context.Context, mcpFlow LoginFlow) (AuthCodeFlow, er
190191

191192
// TODO:This is used to open the browser for GitHub Auth before blocking
192193
if mcpFlow {
193-
browser.OpenURL(server.URL)
194+
err := browser.OpenURL(server.URL)
195+
if err != nil {
196+
return AuthCodeFlow{}, fmt.Errorf("failed to open browser: %w", err)
197+
}
194198
}
195199

196200
input := term.NewNonBlockingStdin()
@@ -205,7 +209,11 @@ func StartAuthCodeFlow(ctx context.Context, mcpFlow LoginFlow) (AuthCodeFlow, er
205209
case 3: // Ctrl-C
206210
cancel()
207211
case 10, 13: // Enter or Return
208-
browser.OpenURL(server.URL)
212+
err := browser.OpenURL(server.URL)
213+
if err != nil {
214+
term.Errorf("failed to open browser: %v", err)
215+
}
216+
default:
209217
}
210218
}
211219
}()

0 commit comments

Comments
 (0)