Fix: Reservations warning should mention defaults (Issue #447) (#589)

shubhrad1 · web-flow · commit d25597a48735 · 2024-08-10T11:33:57.000-07:00
* Changed memory reservation warning message to suggest provider-specific defaults are used.

* Fixed typo 'specify' -&gt; 'Specify'
diff --git a/src/pkg/cli/compose/validation.go b/src/pkg/cli/compose/validation.go
@@ -239,7 +239,7 @@ func ValidateProject(project *compose.Project) error {
 			}
 		}
 		if reservations == nil || reservations.MemoryBytes == 0 {
-			term.Warnf("service %q: missing memory reservation; specify deploy.resources.reservations.memory to avoid out-of-memory errors", svccfg.Name)
+			term.Warnf("service %q: missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors", svccfg.Name)
 		}
 
 		if dnsRoleVal := svccfg.Extensions["x-defang-dns-role"]; dnsRoleVal != nil {

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ func ValidateProject(project *compose.Project) error {`
`239`	`239`	`}`
`240`	`240`	`}`
`241`	`241`	`if reservations == nil \|\| reservations.MemoryBytes == 0 {`
`242`		`- term.Warnf("service %q: missing memory reservation; specify deploy.resources.reservations.memory to avoid out-of-memory errors", svccfg.Name)`
	`242`	`+ term.Warnf("service %q: missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors", svccfg.Name)`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`if dnsRoleVal := svccfg.Extensions["x-defang-dns-role"]; dnsRoleVal != nil {`