remove obsolete command fixup from compose generation (#1396)

Author: jordanstephens

src/pkg/migrate/migrate.go

@@ -9,7 +9,6 @@ import (
 	"slices"
 	"strings"
 
-	"al.essio.dev/pkg/shellescape"
 	"github.com/DefangLabs/defang/src/pkg/cli/client"
 	"github.com/DefangLabs/defang/src/pkg/cli/compose"
 	"github.com/DefangLabs/defang/src/pkg/surveyor"
@@ -233,50 +232,6 @@ func cleanupComposeFile(in string) (string, error) {
 							})
 						}
 					}
-
-					// railpack generates images with `Entrypoint: "bash -c"`, and
-					// compose-go normalizes string commands into arrays, for example:
-					// `command: npm start` -> `command: [ "npm", "start" ]`. As a
-					// result, the command which ultimately gets run is
-					// `bash -c npm start`. When this gets run, `bash` will ignore
-					// `start` and `npm` will get run in a subprocess--only printing
-					// the help text. As it is common for users to type their service
-					// command as a string, this cleanup step will help ensure the
-					// command is run as intended by replacing `command: npm start`
-					// with `command: [ "npm start" ]`.
-					if kk.Value == "command" {
-						if vk.Kind == yaml.ScalarNode {
-							cmd := vk.Value
-							vk.Value = ""
-							vk.Kind = yaml.SequenceNode
-							vk.Tag = "!!seq"
-							vk.Content = []*yaml.Node{
-								{
-									Tag:   "!!str",
-									Kind:  yaml.ScalarNode,
-									Value: cmd,
-								},
-							}
-						}
-						// We will do the same for
-						// `command: ["npm", "start"]`, which will also get transformed
-						// to `command: [ "npm start" ]`.
-						if vk.Kind == yaml.SequenceNode && len(vk.Content) > 1 {
-							var parts []string
-							for _, c := range vk.Content {
-								parts = append(parts, c.Value)
-							}
-							cmd := shellescape.QuoteCommand(parts)
-							// combine content nodes into one
-							vk.Content = []*yaml.Node{
-								{
-									Tag:   "!!str",
-									Kind:  yaml.ScalarNode,
-									Value: cmd,
-								},
-							}
-						}
-					}
 				}
 			}
 		}

src/pkg/migrate/migrate_test.go

@@ -469,58 +469,6 @@ services:
     db:
         image: postgres:latest # EOL comment
         x-defang-postgres: "true"
-`,
-			expectingError: false,
-		},
-		{
-			name: "string command",
-			input: `
-services:
-  web:
-    build: .
-    command: npm start
-`,
-			expected: `services:
-    web:
-        build: .
-        command:
-            - npm start
-`,
-			expectingError: false,
-		},
-		{
-			name: "array command",
-			input: `
-services:
-  web:
-    build: .
-    command:
-      - npm
-      - start
-`,
-			expected: `services:
-    web:
-        build: .
-        command:
-            - npm start
-`,
-			expectingError: false,
-		},
-		{
-			name: "array command with multiple words",
-			input: `
-services:
-  web:
-    build: .
-    command:
-      - echo
-      - hello world
-`,
-			expected: `services:
-    web:
-        build: .
-        command:
-            - echo 'hello world'
 `,
 			expectingError: false,
 		},