refactor: replace sort with slices for improved sorting functionality

Author: lionello

src/cmd/cli/command/commands.go

@@ -9,7 +9,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"regexp"
-	"sort"
+	"slices"
 	"strings"
 	"time"
 
@@ -443,7 +443,9 @@ var tenantsCmd = &cobra.Command{
 		}
 
 		// Sort by name for stable output
-		sort.Slice(tenants, func(i, j int) bool { return strings.ToLower(tenants[i].Name) < strings.ToLower(tenants[j].Name) })
+		slices.SortFunc(tenants, func(a, b auth.Tenant) int {
+			return strings.Compare(strings.ToLower(a.Name), strings.ToLower(b.Name))
+		})
 
 		if len(tenants) == 0 {
 			term.Info("No tenants found")

src/pkg/cli/compose/validation.go

@@ -8,7 +8,6 @@ import (
 	"path/filepath"
 	"regexp"
 	"slices"
-	"sort"
 	"strconv"
 	"strings"
 	"time"
@@ -38,8 +37,8 @@ func ValidateProject(project *composeTypes.Project) error {
 	for _, svccfg := range project.Services {
 		services = append(services, svccfg)
 	}
-	sort.Slice(services, func(i, j int) bool {
-		return services[i].Name < services[j].Name
+	slices.SortFunc(services, func(a, b composeTypes.ServiceConfig) int {
+		return strings.Compare(a.Name, b.Name)
 	})
 
 	var errs []error

src/pkg/cli/deploymentsList.go

@@ -2,7 +2,7 @@ package cli
 
 import (
 	"context"
-	"sort"
+	"slices"
 	"strings"
 	"time"
 
@@ -60,8 +60,8 @@ func DeploymentsList(ctx context.Context, listType defangv1.DeploymentType, proj
 		// TODO: allow user to specify sort order
 		sortKeys[i] = strings.Join([]string{d.ProjectName, d.Provider, d.AccountId, d.Region}, "|")
 	}
-	sort.SliceStable(sortKeys, func(i, j int) bool {
-		return sortKeys[i] < sortKeys[j]
+	slices.SortStableFunc(sortKeys, func(a, b string) int {
+		return strings.Compare(a, b)
 	})
 
 	return term.Table(deployments, []string{"ProjectName", "Provider", "AccountId", "Region", "Deployment", "DeployedAt"})

src/pkg/cli/estimate.go

@@ -6,7 +6,7 @@ import (
 	"fmt"
 	"io"
 	"os"
-	"sort"
+	"slices"
 	"strconv"
 	"strings"
 	"time"
@@ -165,8 +165,8 @@ func prepareEstimateLineItemTableItems(lineItems []*defangv1.EstimateLineItem) [
 	}
 
 	// sort line items by service + description
-	sort.Slice(tableItems, func(i, j int) bool {
-		return tableItems[i].Service+tableItems[i].Description < tableItems[j].Service+tableItems[j].Description
+	slices.SortFunc(tableItems, func(a, b EstimateLineItemTableItem) int {
+		return strings.Compare(a.Service+a.Description, b.Service+b.Description)
 	})
 
 	return tableItems

src/pkg/dns/resolver.go

@@ -6,7 +6,7 @@ import (
 	"fmt"
 	"net"
 	"slices"
-	"sort"
+	"strings"
 
 	"github.com/DefangLabs/defang/src/pkg"
 	"github.com/miekg/dns"
@@ -76,7 +76,9 @@ func FindNSServers(ctx context.Context, domain string) ([]*net.NS, error) {
 		index := pkg.RandomIndex(len(nsServers))
 		nsServer := nsServers[index].Host
 		ns, err := ResolverAt(nsServer).LookupNS(ctx, domain)
-		sort.Slice(ns, func(i, j int) bool { return ns[i].Host < ns[j].Host })
+		slices.SortFunc(ns, func(a, b *net.NS) int {
+			return strings.Compare(a.Host, b.Host)
+		})
 		if err != nil {
 			if retries--; retries > 0 {
 				continue