Skip to content

Conversation

lionello
Copy link
Member

@lionello lionello commented May 22, 2024

Not sure what's the best way to show code; now using "invert" which looks a bit like GitHub:
image

@@ -29,7 +29,7 @@ func validateProject(project *compose.Project) error {
warnf("unsupported compose directive: read_only")
}
if svccfg.Restart == "" {
warnf("missing compose directive: restart; assuming 'unless-stopped' (add 'restart' to silence)")
warnf("missing compose directive: `restart`; assuming 'unless-stopped' (add 'restart' to silence)")
} else if svccfg.Restart != "always" && svccfg.Restart != "unless-stopped" {
warnf("unsupported compose directive: restart; assuming 'unless-stopped' (add 'restart' to silence)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restart should be marked code here too.

@lionello lionello added the DX Affects developer experience label May 22, 2024
Copy link
Contributor

@edwardrf edwardrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lionello lionello marked this pull request as draft May 28, 2024 19:42
@acote88 acote88 added this to the Sep2024 milestone Sep 3, 2024
@lionello lionello modified the milestones: Sep2024, Oct2024 Oct 25, 2024
Copy link
Member

@jordanstephens jordanstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@lionello lionello modified the milestones: Oct2024, V1, V2 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affects developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants