read from stdout and stderr concurrently

Co-authored-by: Copilot <[email protected]>

Author: jordanstephens

app/get_knowledge_base.py

@@ -42,21 +42,24 @@ def run_command(command, label):
         bufsize=1
     )
 
-    # log stdout
-    for line in iter(process.stdout.readline, ''):
-        if line.strip():
-            logging.info(f"{label}: {line.rstrip()}")
-
-    # log stderr
-    for line in iter(process.stderr.readline, ''):
-        if line.strip():
-            logging.error(f"{label}: {line.rstrip()}")
-
-    # Wait for process to complete and check return code
-    return_code = process.wait()
-    if return_code != 0:
-        raise subprocess.CalledProcessError(return_code, command)
-
+    # Read both stdout and stderr concurrently
+    stdout, stderr = process.communicate()
+
+    # Log stdout
+    if stdout:
+        for line in stdout.splitlines():
+            if line.strip():
+                logging.info(f"{label}: {line}")
+
+    # Log stderr
+    if stderr:
+        for line in stderr.splitlines():
+            if line.strip():
+                logging.error(f"{label}: {line}")
+
+    # Check return code
+    if process.returncode != 0:
+        raise subprocess.CalledProcessError(process.returncode, command)
 def run_prebuild_script():
     """ Run the defang-docs repo prebuild script"""