Revert "Revert get param to ServiceID"

This reverts commit 49eebc7.

Author: lionello

index.ts

@@ -718,7 +718,7 @@ const defangServiceProvider: pulumi.dynamic.ResourceProvider<
     id: string,
     olds?: DefangServiceOutputs
   ): Promise<pulumi.dynamic.ReadResult<DefangServiceOutputs>> {
-    const serviceId = new pb.ServiceID();
+    const serviceId = new pb.GetRequest();
     // serviceId.setProject(project);
     serviceId.setName(id);
     assert(olds?.fabricDNS, "fabricDNS is required");

io/defang/v1/fabric.proto

@@ -24,7 +24,7 @@ service FabricController {
     option deprecated = true;
   }; // used by pulumi-defang provider; should use Deploy
   rpc Deploy(DeployRequest) returns (DeployResponse);
-  rpc Get(ServiceID) returns (ServiceInfo) {
+  rpc Get(GetRequest) returns (ServiceInfo) {
     option idempotency_level = NO_SIDE_EFFECTS;
   }; // should be GetService
   rpc Delete(DeleteRequest) returns (DeleteResponse) {

protos/io/defang/v1/fabric_grpc_pb.d.ts

@@ -15,7 +15,7 @@ interface IFabricControllerService extends grpc.ServiceDefinition<grpc.UntypedSe
   tail: grpc.MethodDefinition<io_defang_v1_fabric_pb.TailRequest, io_defang_v1_fabric_pb.TailResponse>;
   update: grpc.MethodDefinition<io_defang_v1_fabric_pb.Service, io_defang_v1_fabric_pb.ServiceInfo>;
   deploy: grpc.MethodDefinition<io_defang_v1_fabric_pb.DeployRequest, io_defang_v1_fabric_pb.DeployResponse>;
-  get: grpc.MethodDefinition<io_defang_v1_fabric_pb.ServiceID, io_defang_v1_fabric_pb.ServiceInfo>;
+  get: grpc.MethodDefinition<io_defang_v1_fabric_pb.GetRequest, io_defang_v1_fabric_pb.ServiceInfo>;
   delete: grpc.MethodDefinition<io_defang_v1_fabric_pb.DeleteRequest, io_defang_v1_fabric_pb.DeleteResponse>;
   destroy: grpc.MethodDefinition<io_defang_v1_fabric_pb.DestroyRequest, io_defang_v1_fabric_pb.DestroyResponse>;
   publish: grpc.MethodDefinition<io_defang_v1_fabric_pb.PublishRequest, google_protobuf_empty_pb.Empty>;
@@ -56,7 +56,7 @@ export interface IFabricControllerServer extends grpc.UntypedServiceImplementati
   tail: grpc.handleServerStreamingCall<io_defang_v1_fabric_pb.TailRequest, io_defang_v1_fabric_pb.TailResponse>;
   update: grpc.handleUnaryCall<io_defang_v1_fabric_pb.Service, io_defang_v1_fabric_pb.ServiceInfo>;
   deploy: grpc.handleUnaryCall<io_defang_v1_fabric_pb.DeployRequest, io_defang_v1_fabric_pb.DeployResponse>;
-  get: grpc.handleUnaryCall<io_defang_v1_fabric_pb.ServiceID, io_defang_v1_fabric_pb.ServiceInfo>;
+  get: grpc.handleUnaryCall<io_defang_v1_fabric_pb.GetRequest, io_defang_v1_fabric_pb.ServiceInfo>;
   delete: grpc.handleUnaryCall<io_defang_v1_fabric_pb.DeleteRequest, io_defang_v1_fabric_pb.DeleteResponse>;
   destroy: grpc.handleUnaryCall<io_defang_v1_fabric_pb.DestroyRequest, io_defang_v1_fabric_pb.DestroyResponse>;
   publish: grpc.handleUnaryCall<io_defang_v1_fabric_pb.PublishRequest, google_protobuf_empty_pb.Empty>;
@@ -109,9 +109,9 @@ export class FabricControllerClient extends grpc.Client {
   deploy(argument: io_defang_v1_fabric_pb.DeployRequest, callback: grpc.requestCallback<io_defang_v1_fabric_pb.DeployResponse>): grpc.ClientUnaryCall;
   deploy(argument: io_defang_v1_fabric_pb.DeployRequest, metadataOrOptions: grpc.Metadata | grpc.CallOptions | null, callback: grpc.requestCallback<io_defang_v1_fabric_pb.DeployResponse>): grpc.ClientUnaryCall;
   deploy(argument: io_defang_v1_fabric_pb.DeployRequest, metadata: grpc.Metadata | null, options: grpc.CallOptions | null, callback: grpc.requestCallback<io_defang_v1_fabric_pb.DeployResponse>): grpc.ClientUnaryCall;
-  get(argument: io_defang_v1_fabric_pb.ServiceID, callback: grpc.requestCallback<io_defang_v1_fabric_pb.ServiceInfo>): grpc.ClientUnaryCall;
-  get(argument: io_defang_v1_fabric_pb.ServiceID, metadataOrOptions: grpc.Metadata | grpc.CallOptions | null, callback: grpc.requestCallback<io_defang_v1_fabric_pb.ServiceInfo>): grpc.ClientUnaryCall;
-  get(argument: io_defang_v1_fabric_pb.ServiceID, metadata: grpc.Metadata | null, options: grpc.CallOptions | null, callback: grpc.requestCallback<io_defang_v1_fabric_pb.ServiceInfo>): grpc.ClientUnaryCall;
+  get(argument: io_defang_v1_fabric_pb.GetRequest, callback: grpc.requestCallback<io_defang_v1_fabric_pb.ServiceInfo>): grpc.ClientUnaryCall;
+  get(argument: io_defang_v1_fabric_pb.GetRequest, metadataOrOptions: grpc.Metadata | grpc.CallOptions | null, callback: grpc.requestCallback<io_defang_v1_fabric_pb.ServiceInfo>): grpc.ClientUnaryCall;
+  get(argument: io_defang_v1_fabric_pb.GetRequest, metadata: grpc.Metadata | null, options: grpc.CallOptions | null, callback: grpc.requestCallback<io_defang_v1_fabric_pb.ServiceInfo>): grpc.ClientUnaryCall;
   delete(argument: io_defang_v1_fabric_pb.DeleteRequest, callback: grpc.requestCallback<io_defang_v1_fabric_pb.DeleteResponse>): grpc.ClientUnaryCall;
   delete(argument: io_defang_v1_fabric_pb.DeleteRequest, metadataOrOptions: grpc.Metadata | grpc.CallOptions | null, callback: grpc.requestCallback<io_defang_v1_fabric_pb.DeleteResponse>): grpc.ClientUnaryCall;
   delete(argument: io_defang_v1_fabric_pb.DeleteRequest, metadata: grpc.Metadata | null, options: grpc.CallOptions | null, callback: grpc.requestCallback<io_defang_v1_fabric_pb.DeleteResponse>): grpc.ClientUnaryCall;

protos/io/defang/v1/fabric_grpc_pb.js

@@ -195,6 +195,17 @@ function deserialize_io_defang_v1_GetConfigsResponse(buffer_arg) {
   return io_defang_v1_fabric_pb.GetConfigsResponse.deserializeBinary(new Uint8Array(buffer_arg));
 }
 
+function serialize_io_defang_v1_GetRequest(arg) {
+  if (!(arg instanceof io_defang_v1_fabric_pb.GetRequest)) {
+    throw new Error('Expected argument of type io.defang.v1.GetRequest');
+  }
+  return Buffer.from(arg.serializeBinary());
+}
+
+function deserialize_io_defang_v1_GetRequest(buffer_arg) {
+  return io_defang_v1_fabric_pb.GetRequest.deserializeBinary(new Uint8Array(buffer_arg));
+}
+
 function serialize_io_defang_v1_GetSelectedProviderRequest(arg) {
   if (!(arg instanceof io_defang_v1_fabric_pb.GetSelectedProviderRequest)) {
     throw new Error('Expected argument of type io.defang.v1.GetSelectedProviderRequest');
@@ -305,17 +316,6 @@ function deserialize_io_defang_v1_Service(buffer_arg) {
   return io_defang_v1_fabric_pb.Service.deserializeBinary(new Uint8Array(buffer_arg));
 }
 
-function serialize_io_defang_v1_ServiceID(arg) {
-  if (!(arg instanceof io_defang_v1_fabric_pb.ServiceID)) {
-    throw new Error('Expected argument of type io.defang.v1.ServiceID');
-  }
-  return Buffer.from(arg.serializeBinary());
-}
-
-function deserialize_io_defang_v1_ServiceID(buffer_arg) {
-  return io_defang_v1_fabric_pb.ServiceID.deserializeBinary(new Uint8Array(buffer_arg));
-}
-
 function serialize_io_defang_v1_ServiceInfo(arg) {
   if (!(arg instanceof io_defang_v1_fabric_pb.ServiceInfo)) {
     throw new Error('Expected argument of type io.defang.v1.ServiceInfo');
@@ -576,10 +576,10 @@ revokeToken: {
     path: '/io.defang.v1.FabricController/Get',
     requestStream: false,
     responseStream: false,
-    requestType: io_defang_v1_fabric_pb.ServiceID,
+    requestType: io_defang_v1_fabric_pb.GetRequest,
     responseType: io_defang_v1_fabric_pb.ServiceInfo,
-    requestSerialize: serialize_io_defang_v1_ServiceID,
-    requestDeserialize: deserialize_io_defang_v1_ServiceID,
+    requestSerialize: serialize_io_defang_v1_GetRequest,
+    requestDeserialize: deserialize_io_defang_v1_GetRequest,
     responseSerialize: serialize_io_defang_v1_ServiceInfo,
     responseDeserialize: deserialize_io_defang_v1_ServiceInfo,
   },