Skip to content

Commit 4c64bb2

Browse files
committed
a bit more guidance around the remove me after editing statements
1 parent 4b20602 commit 4c64bb2

File tree

7 files changed

+13
-4
lines changed

7 files changed

+13
-4
lines changed

starter-sample/.devcontainer/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Note: universal image is not compatible with the devcontainer tools.
22
# we use the typescript-node image instead here but should switch out per
3-
# project requirements. #REMOVE_ME_AFTER_EDITING
3+
# project requirements. You can choose a devcontainer that's appropriate
4+
# for your sample from the list below #REMOVE_ME_AFTER_EDITING
45

56
# FROM mcr.microsoft.com/devcontainers/go:1.22-bookworm
67
# FROM mcr.microsoft.com/devcontainers/python:3.12-bookworm

starter-sample/.github/workflows/deploy.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
- name: Deploy
2020
uses: DefangLabs/[email protected]
2121
#REMOVE_ME_AFTER_EDITING - Replace the following line with the list of environment variables you want to pass to the action
22+
# or remove the lines if you don't need to pass any environment variables/secrets to the action
2223
with:
2324
config-env-vars: ENV1 ENV2
2425
env:

starter-sample/app/.dockerignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
#REMOVE_ME_AFTER_EDITING - This Dockerignore is for a basic node app. Modify as needed.
1+
#REMOVE_ME_AFTER_EDITING - This Dockerignore is for a basic node app. Modify as needed for your sample.
22
node_modules
33
npm-debug.log

starter-sample/app/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
#REMOVE_ME_AFTER_EDITING - This Dockerignore is for a basic node app. Modify as needed.
1+
#REMOVE_ME_AFTER_EDITING - This Dockerignore is for a basic node app. Modify as needed for your sample.
22
node_modules

starter-sample/app/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# A sample dockerfile for a Node.js application.
2-
# Replace with an appropriate Dockerfile for your application.
2+
# Replace with an appropriate Dockerfile for your sample.
33
#REMOVE_ME_AFTER_EDITING
44

55
FROM node:20-bookworm-slim

starter-sample/app/index.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
//#REMOVE_ME_AFTER_EDITING - This is a sample index.js file for a Node.js application.
2+
// Feel free to delete this file. It's just a placeholder.
3+
14
const express = require('express');
25
const { MongoClient } = require('mongodb');
36

starter-sample/compose.dev.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
# for samples where a user may want to hot reload changes in the app, or
44
# if it depends on stateful services like a database that isn't supported
55
# by Defang, like MongoDB.
6+
#
7+
# Note: This dev compose file's services should extend the production
8+
# compose file's services. That way we can keep things consistent across
9+
# dev and production and override only what we need to.
610

711
services:
812
app:

0 commit comments

Comments
 (0)