Skip to content

Commit 6d1fcf5

Browse files
authored
Merge pull request #258 from DefangLabs/linda-fix-bash-samples
Fix bash shell installation to use eval
2 parents 55658ca + 9396cd7 commit 6d1fcf5

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/check-sample.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: Run Checks
2626
id: checks
2727
run: |
28-
. <(curl -Ls https://s.defang.io/install)
28+
eval "$(curl -fsSL s.defang.io/install)"
2929
./scripts/check-sample-files.sh > checklist.txt
3030
./scripts/check-modified-samples.sh > modified.txt
3131
echo "@@ MODIFIED @@"
@@ -35,7 +35,7 @@ jobs:
3535
# once we figure out how to prevent it from erroring on warnings.
3636
# - name: Validate Compose Files with Defang CLI
3737
# run: |
38-
# . <(curl -Ls https://s.defang.io/install)
38+
# eval "$(curl -fsSL s.defang.io/install)"
3939
# cat modified.txt | xargs -n1 defang compose config -C > /dev/null
4040

4141
- name: Add checklist to PR description

samples/nextjs-documentation/app/pages/getting-started/installing.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ brew install defang-io/defang/defang
1717
You can install the Defang CLI using a bash script. Just run the following command in your terminal:
1818

1919
```bash
20-
. <(curl -Ls https://s.defang.io/install)
20+
eval "$(curl -fsSL s.defang.io/install)"
2121
```
2222

2323
The script will try to download the appropriate binary for your operating system and architecture, add it to `~/.local/bin`, and add `~/.local/bin` to your `PATH` if it's not already there, with your permission. If you do not provide permission it will print an appropriate instruction for you to follow to add it manually. You can also customize the installation directory by setting the `INSTALL_DIR` environment variable before running the script.

samples/vllm/ui/src/app/docs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ brew install defang-io/defang/defang
107107
You can install the Defang CLI using a bash script. Just run the following command in your terminal:
108108

109109
```bash
110-
. <(curl -Ls https://s.defang.io/install)
110+
eval "$(curl -fsSL s.defang.io/install)"
111111
```
112112

113113
The script will try to download the appropriate binary for your operating system and architecture, add it to `~/.local/bin`, and add `~/.local/bin` to your `PATH` if it's not already there, with your permission. If you do not provide permission it will print an appropriate instruction for you to follow to add it manually. You can also customize the installation directory by setting the `INSTALL_DIR` environment variable before running the script.

0 commit comments

Comments
 (0)