Skip to content

Commit 9d31641

Browse files
authored
Merge pull request #308 from DefangLabs/detail-test-procedure
Add information about test procedure
2 parents 2e2d411 + a89a8e9 commit 9d31641

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,8 @@ Browse through the [./samples](./samples) directory, or search and browse in the
66

77
## Adding Samples
88

9-
To start working on a new sample, run `. ./scripts/new-sample` from the root of the repository. This will create a new sample directory, with some basic scaffolding to get you started. Look for `#REMOVE_ME_AFTER_EDITING` in your new project to look for things that you should probably be changing/checking per sample. Feel free to remove files, like `compose.dev.yaml` if they aren't necessary for your sample.
9+
To start working on a new sample, run `. ./scripts/new-sample` from the root of the repository. This will create a new sample directory, with some basic scaffolding to get you started. Look for `#REMOVE_ME_AFTER_EDITING` in your new project to look for things that you should probably be changing/checking per sample. Feel free to remove files, like `compose.dev.yaml` if they aren't necessary for your sample.
10+
11+
### Testing Samples
12+
13+
When you add a new sample, make sure to add any config vals to the `deploy-changed-samples.yml` workflow. They need to be prefixed with `TEST_` and those values need to be set in the repo secrets.

starter-sample/compose.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ services:
1313
mode: ingress
1414
environment: # Secrets and env vars #REMOVE_ME_AFTER_EDITING
1515
MONGODB_URI:
16+
#REMOVE_ME_AFTER_EDITING NOTE: If you add any secrets in here, make sure to add them to the `deploy-changed-samples.yml` workflow file as well. See the README for more information.
1617
healthcheck:
1718
# wget or curl required for healthchecks on services with a published port
1819
# this gets parsed by Defang and provided to the load balancers as well

0 commit comments

Comments
 (0)