Merge pull request #133 from DefangLabs/lio-warnings

fix compose warnings

Author: raphaeltm

.github/workflows/check-sample.yml

@@ -8,7 +8,7 @@ on:
 jobs:
   check_samples:
     runs-on: ubuntu-latest
-    permissions: 
+    permissions:
       contents: write
       pull-requests: write
     steps:
@@ -26,20 +26,25 @@ jobs:
           echo "@@ MODIFIED @@"
           cat modified.txt
 
+      - name: Validate Compose Files with Defang CLI
+        run: |
+          . <(curl -Ls https://s.defang.io/install)
+          cat modified.txt | xargs -n1 defang compose config -C > /dev/null
+
       - name: Add checklist to PR description
         uses: actions/github-script@v5
         with:
           script: |
             const fs = require('fs');
             const pr_number = context.issue.number;
             const marker = '## Samples Checklist';
-            
+
             // Read the checklist from the file
             let checklist = fs.readFileSync('checklist.txt', 'utf8').trim();
             let error = false;
 
             if(!checklist) {
-              checklist = "✅"
+              checklist = "✅ All good!"
             }
             else {
               error = true;

samples/bullmq-bullboard-redis/compose.yaml

@@ -1,5 +1,6 @@
 services:
   board:
+    restart: unless-stopped
     build:
       context: ./board
       dockerfile: Dockerfile
@@ -15,6 +16,7 @@ services:
       - redis
 
   api:
+    restart: unless-stopped
     build:
       context: ./api
       dockerfile: Dockerfile
@@ -29,6 +31,7 @@ services:
       - redis
 
   worker:
+    restart: unless-stopped
     deploy:
       replicas: 2
     build:

samples/django-postgres/compose.yaml

@@ -1,5 +1,6 @@
 services:
   db:
+    restart: unless-stopped
     image: postgres:14
     volumes: ["./tmp/postgres:/var/lib/postgresql/data/"]
     environment:
@@ -18,9 +19,9 @@ services:
       interval: 1m30s
       timeout: 30s
       retries: 5
-      start_period: 30s
   django-crm:
-    build: .
+    restart: unless-stopped
+    build: ./app
     ports:
       - mode: ingress
         target: 8000

samples/django/compose.yaml

@@ -1,5 +1,6 @@
 services:
   django:
+    restart: unless-stopped
     build:
       context: ./app
       dockerfile: Dockerfile

samples/fastapi-postgres/compose.yaml

@@ -1,5 +1,6 @@
 services:
   fastapi:
+    restart: unless-stopped
     build:
       context: ./fastapi
       dockerfile: Dockerfile

samples/golang-slackbot/compose.yaml

@@ -1,5 +1,6 @@
 services:
   bot:
+    restart: unless-stopped
     build:
       context: ./app
       dockerfile: Dockerfile

samples/hasura/compose.yaml

@@ -1,5 +1,6 @@
 services:
   hasura:
+    restart: unless-stopped
     build:
       dockerfile: Dockerfile
       context: ./hasura

samples/huginn/compose.yaml

@@ -16,7 +16,6 @@ services:
       interval: 1m30s
       timeout: 30s
       retries: 10
-      start_period: 30s
     environment:
       - DATABASE_ADAPTER=postgresql
       - DATABASE_NAME

samples/metabase/compose.yaml

@@ -1,5 +1,6 @@
 services:
   metabase:
+    restart: unless-stopped
     image: "metabase/metabase:latest"
     ports:
       - mode: ingress

samples/nextjs-blog/compose.yaml

@@ -1,5 +1,6 @@
 services:
   blogstarter:
+    restart: unless-stopped
     build:
       context: ./app
       dockerfile: Dockerfile