Ruff: Add PLC0206 (#12426)

* Ruff: Add PLC0206

* 💄

* update

* Update dojo/utils.py

Co-authored-by: kiblik <[email protected]>

* update

* revert

* update

* Update dojo/tools/factory.py

Co-authored-by: kiblik <[email protected]>

---------

Co-authored-by: kiblik <[email protected]>

Author: manuel-sommer

dojo/tools/checkmarx/parser.py

@@ -176,9 +176,9 @@ def _get_findings_xml(self, filename, test):
                     dupes[key].vuln_id_from_tool = ",".join(
                         vuln_ids_from_tool[key],
                     )[:500]
-        for lang in language_list:
+        for lang, file in language_list.items():
             add_language(
-                test.engagement.product, lang, files=language_list[lang],
+                test.engagement.product, lang, files=file,
             )
 
         return list(dupes.values())

dojo/tools/mobsf_scorecard/parser.py

@@ -78,22 +78,22 @@ def get_findings(self, filename, test):
 
         dd_findings = {}
 
-        for finding_severity in finding_severities:
-            if finding_severity in data.get("appsec", {}):
-                for mobsf_finding in data["appsec"][finding_severity]:
+        for mobsf_severity, defectdojo_severity in finding_severities.items():
+            if mobsf_severity in data.get("appsec", {}):
+                for mobsf_finding in data["appsec"][mobsf_severity]:
 
                     section = str(mobsf_finding.get("section", ""))
                     title = str(mobsf_finding.get("title", ""))
                     description = str(mobsf_finding.get("description", ""))
 
-                    unique_key = f"{finding_severity}-{section}-{title}-{description}"
+                    unique_key = f"{mobsf_severity}-{section}-{title}-{description}"
 
                     finding = Finding(
                             title=title,
                             cwe=919,  # Weaknesses in Mobile Applications
                             test=test,
                             description=f"**Category:** {section}\n\n{description}",
-                            severity=finding_severities[finding_severity],
+                            severity=defectdojo_severity,
                             references=None,
                             date=find_date,
                             static_finding=True,

dojo/tools/nmap/parser.py

@@ -172,12 +172,12 @@ def manage_vulner_script(
                 description = "### Vulnerability\n\n"
                 description += "**ID**: `" + str(vuln_id) + "`\n"
                 description += "**CPE**: " + str(component_cpe) + "\n"
-                for attribute in vuln_attributes:
+                for attribute, value in vuln_attributes.items():
                     description += (
                         "**"
                         + attribute
                         + "**: `"
-                        + vuln_attributes[attribute]
+                        + value
                         + "`\n"
                     )
                 severity = self.convert_cvss_score(vuln_attributes["cvss"])

dojo/utils.py

@@ -1904,17 +1904,17 @@ def _notification_title_for_finding(finding, kind, sla_age):
         return title
 
     def _create_notifications():
-        for pt in combined_notifications:
-            for p in combined_notifications[pt]:
-                for kind in combined_notifications[pt][p]:
+        for prodtype, comb_notif_prodtype in combined_notifications.items():
+            for prod, comb_notif_prod in comb_notif_prodtype.items():
+                for kind, comb_notif_kind in comb_notif_prod.items():
                     # creating notifications on per-finding basis
 
                     # we need this list for combined notification feature as we
                     # can not supply references to local objects as
                     # create_notification() arguments
                     findings_list = []
 
-                    for n in combined_notifications[pt][p][kind]:
+                    for n in comb_notif_kind:
                         title = _notification_title_for_finding(n.finding, kind, n.finding.sla_days_remaining())
 
                         create_notification(
@@ -1931,8 +1931,8 @@ def _create_notifications():
                         findings_list.append(n.finding)
 
                     # producing a "combined" SLA breach notification
-                    title_combined = f"SLA alert ({kind}): product type '{pt}', product '{p}'"
-                    product = combined_notifications[pt][p][kind][0].finding.test.engagement.product
+                    title_combined = f"SLA alert ({kind}): product type '{prodtype}', product '{prod}'"
+                    product = comb_notif_kind[0].finding.test.engagement.product
                     create_notification(
                         event="sla_breach_combined",
                         title=title_combined,

ruff.toml

@@ -74,7 +74,7 @@ select = [
    "FIX",
    "PD",
    "PGH",
-   "PLC01", "PLC0205", "PLC0208", "PLC0414", "PLC18", "PLC24", "PLC28", "PLC3",
+   "PLC01", "PLC02", "PLC0414", "PLC18", "PLC24", "PLC28", "PLC3",
    "PLE",
    "PLR01", "PLR02", "PLR04", "PLR0915", "PLR1716", "PLR172", "PLR173", "PLR2044", "PLR5", "PLR6104", "PLR6201",
    "PLW01", "PLW02", "PLW04", "PLW0602", "PLW0604", "PLW07", "PLW1", "PLW2", "PLW3",