Skip to content

Commit 27ddc19

Browse files
authored
Merge pull request #1159 from Maffooch/dev
Credential Modifications
2 parents 104e89f + d1b1ec5 commit 27ddc19

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

tests/Product_unit_test_example.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,19 @@
33
import unittest
44
import re
55
import sys
6+
import os
67

78

89
class ProductTest(unittest.TestCase):
910
def setUp(self):
1011
# Initialize the driver
12+
# When used with Travis, chromdriver is stored in the same
13+
# directory as the unit tests
1114
self.driver = webdriver.Chrome('chromedriver')
1215
# Allow a little time for the driver to initialize
1316
self.driver.implicitly_wait(30)
1417
# Set the base address of the dojo
15-
self.base_url = "http://localhost:8080/"
18+
self.base_url = "http://localhost:8000/"
1619
self.verificationErrors = []
1720
self.accept_next_alert = True
1821

@@ -23,12 +26,12 @@ def login_page(self):
2326
driver.get(self.base_url + "login")
2427
# Good practice to clear the entry before typing
2528
driver.find_element_by_id("id_username").clear()
26-
# Set the user to an admin account
27-
driver.find_element_by_id("id_username").send_keys('admin')
29+
# These credentials will be used by Travis when testing new PRs
30+
# They will not work when testing on your own build
31+
# Be sure to change them before submitting a PR
32+
driver.find_element_by_id("id_username").send_keys(os.environ['DD_ADMIN_USER'])
2833
driver.find_element_by_id("id_password").clear()
29-
# Use the password unqiue to the container. Info on finding this below
30-
# https://github.com/DefectDojo/django-DefectDojo/blob/master/DOCKER.md
31-
driver.find_element_by_id("id_password").send_keys('eE1F6IKz3Uq4rLg6aYtI0k')
34+
driver.find_element_by_id("id_password").send_keys(os.environ['DD_ADMIN_PASSWORD'])
3235
# "Click" the but the login button
3336
driver.find_element_by_css_selector("button.btn.btn-success").click()
3437
return driver

tests/check_status.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ def login_page(self):
2323
driver.get(self.base_url + "login")
2424
cred_user_elem = driver.find_element_by_id("id_username")
2525
cred_user_elem.clear()
26-
cred_user_elem.send_keys(os.environ['DOJO_ADMIN_USER'])
26+
cred_user_elem.send_keys(os.environ['DD_ADMIN_USER'])
2727
cred_pass_elem = driver.find_element_by_id("id_password")
2828
cred_pass_elem.clear()
29-
cred_pass_elem.send_keys(os.environ['DOJO_ADMIN_PASSWORD'])
29+
cred_pass_elem.send_keys(os.environ['DD_ADMIN_PASSWORD'])
3030
driver.find_element_by_css_selector("button.btn.btn-success").click()
3131
return driver
3232

tests/check_status_ui.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ def login_page(self):
2121
driver = self.driver
2222
driver.get(self.base_url + "login")
2323
driver.find_element_by_id("id_username").clear()
24-
driver.find_element_by_id("id_username").send_keys(os.environ['DOJO_ADMIN_USER'])
25-
driver.find_element_by_id("id_password").send_keys(os.environ['DOJO_ADMIN_PASSWORD'])
24+
driver.find_element_by_id("id_username").send_keys(os.environ['DD_ADMIN_USER'])
25+
driver.find_element_by_id("id_password").send_keys(os.environ['DD_ADMIN_PASSWORD'])
2626
driver.find_element_by_css_selector("button.btn.btn-success").click()
2727
return driver
2828

tests/smoke_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ def login_page(self):
2020
driver = self.driver
2121
driver.get(self.base_url + "login")
2222
driver.find_element_by_id("id_username").clear()
23-
driver.find_element_by_id("id_username").send_keys(os.environ['DOJO_ADMIN_USER'])
23+
driver.find_element_by_id("id_username").send_keys(os.environ['DD_ADMIN_USER'])
2424
driver.find_element_by_id("id_password").clear()
25-
driver.find_element_by_id("id_password").send_keys(os.environ['DOJO_ADMIN_PASSWORD'])
25+
driver.find_element_by_id("id_password").send_keys(os.environ['DD_ADMIN_PASSWORD'])
2626
driver.find_element_by_css_selector("button.btn.btn-success").click()
2727
return driver
2828

0 commit comments

Comments
 (0)