Skip to content

Commit 27f0008

Browse files
authored
Merge pull request #514 from aaronweaver/master
Update links to correct 404 on Product Metric Page
2 parents 9d05517 + bdb628c commit 27f0008

File tree

3 files changed

+27
-6
lines changed

3 files changed

+27
-6
lines changed

dojo/metrics/views.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ def critical_product_metrics(request, mtype):
4242
add_breadcrumb(title=page_name, top_level=not len(request.GET), request=request)
4343
return render(request, template, {
4444
'name': page_name,
45-
'critical_prods': critical_products
45+
'critical_prods': critical_products,
46+
'url_prefix': get_system_setting('url_prefix')
4647
})
4748

4849
@cache_page(60 * 5) # cache for 5 minutes

dojo/models.py

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,6 +1364,22 @@ class App_Analysis(models.Model):
13641364
website_found = models.URLField(max_length=400, null=True, blank=True)
13651365
created = models.DateTimeField(null=False, editable=False, default=now)
13661366

1367+
class Objects_Review(models.Model):
1368+
name = models.CharField(max_length=100, null=True)
1369+
created = models.DateTimeField(null=False, editable=False, default=now)
1370+
1371+
class Objects(models.Model):
1372+
engagement = models.ForeignKey(Engagement)
1373+
name = models.CharField(max_length=100, null=True)
1374+
path = models.CharField(max_length=600, null=False)
1375+
review_status = models.ForeignKey(Objects_Review)
1376+
created = models.DateTimeField(null=False, editable=False, default=now)
1377+
1378+
class Objects_Engagement(models.Model):
1379+
engagement = models.ForeignKey(Engagement)
1380+
object = models.ForeignKey(Objects)
1381+
created = models.DateTimeField(null=False, editable=False, default=now)
1382+
13671383
# Register for automatic logging to database
13681384
auditlog.register(Dojo_User)
13691385
auditlog.register(Endpoint)
@@ -1383,7 +1399,11 @@ class App_Analysis(models.Model):
13831399
tag_register(Endpoint)
13841400
tag_register(Finding_Template)
13851401
tag_register(App_Analysis)
1402+
tag_register(Objects)
13861403

1404+
admin.site.register(Objects)
1405+
admin.site.register(Objects_Review)
1406+
admin.site.register(Objects_Engagement)
13871407
admin.site.register(Languages)
13881408
admin.site.register(Language_Type)
13891409
admin.site.register(App_Analysis)

dojo/templates/dojo/metrics.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,24 +141,24 @@ <h3 {% if not critical_prods %}class="has-filters" {% endif %}>
141141
<p> {{ c_prod.name }} is affected by <b>both</b> critical and high severity
142142
vulnerabilities.</p>
143143
<p>
144-
<a href="/dojo/finding/open?title=&date=&severity=Critical&mitigated_by=&last_reviewed_by=&last_reviewed=&test__engagement__product__prod_type={{ c_prod.id }}&o=numerical_severity&page_size=25">Critical
144+
<a href="{{ url_prefix }}/finding/open?title=&date=&severity=Critical&mitigated_by=&last_reviewed_by=&last_reviewed=&test__engagement__product__prod_type={{ c_prod.id }}&o=numerical_severity&page_size=25">Critical
145145
Severity Vulnerabilities</a></p>
146146
<p>
147-
<a href="/dojo/finding/open?title=&date=&severity=High&mitigated_by=&last_reviewed_by=&last_reviewed=&test__engagement__product__prod_type={{ c_prod.id }}&o=numerical_severity&page_size=25">High
147+
<a href="{{ url_prefix }}/finding/open?title=&date=&severity=High&mitigated_by=&last_reviewed_by=&last_reviewed=&test__engagement__product__prod_type={{ c_prod.id }}&o=numerical_severity&page_size=25">High
148148
Severity Vulnerabilities</a></p>
149149
{% elif c_prod.critical_present %}
150150
<p> {{ c_prod.name }} is affected by critical vulnerabilities. </p>
151151
<p>
152-
<a href="/dojo/finding/open?title=&date=&severity=Critical&mitigated_by=&last_reviewed_by=&last_reviewed=&test__engagement__product__prod_type={{ c_prod.id }}&o=numerical_severity&page_size=25">Critical
152+
<a href="{{ url_prefix }}/finding/open?title=&date=&severity=Critical&mitigated_by=&last_reviewed_by=&last_reviewed=&test__engagement__product__prod_type={{ c_prod.id }}&o=numerical_severity&page_size=25">Critical
153153
Severity Vulnerabilities</a></p>
154154
{% elif c_prod.high_present %}
155155
<p> {{ c_prod.name }} is affected by high severity vulnerabilities.</p>
156156
<p>
157-
<a href="/dojo/finding/open?title=&date=&severity=High&mitigated_by=&last_reviewed_by=&last_reviewed=&test__engagement__product__prod_type={{ c_prod.id }}&o=numerical_severity&page_size=25">High
157+
<a href="{{ url_prefix }}/finding/open?title=&date=&severity=High&mitigated_by=&last_reviewed_by=&last_reviewed=&test__engagement__product__prod_type={{ c_prod.id }}&o=numerical_severity&page_size=25">High
158158
Severity Vulnerabilities</a></p>
159159
{% endif %}
160160
<p>
161-
<a href='/dojo/metrics/product/type?date=2&test__engagement__product__prod_type={{ c_prod.id }}&status='>
161+
<a href='{{ url_prefix }}/metrics/product/type?date=2&test__engagement__product__prod_type={{ c_prod.id }}&status='>
162162
Full Metrics</a></p></div>
163163
<br>
164164
</div>

0 commit comments

Comments
 (0)