Skip to content

Commit 4f590d0

Browse files
authored
Increase alert field size to 250 (#3682)
* increase alert field size to 200 * bump to 250 * ajust truncation to 250 * remove url truncate
1 parent d57c174 commit 4f590d0

File tree

3 files changed

+22
-4
lines changed

3 files changed

+22
-4
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Generated by Django 2.2.17 on 2021-01-22 12:34
2+
3+
from django.db import migrations, models
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
('dojo', '0069_risk_acceptance'),
10+
]
11+
12+
operations = [
13+
migrations.AlterField(
14+
model_name='alerts',
15+
name='title',
16+
field=models.CharField(default='', max_length=250),
17+
),
18+
]

dojo/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2829,7 +2829,7 @@ class Tool_Product_History(models.Model):
28292829

28302830

28312831
class Alerts(models.Model):
2832-
title = models.CharField(max_length=100, default='', null=False)
2832+
title = models.CharField(max_length=250, default='', null=False)
28332833
description = models.CharField(max_length=2000, null=True)
28342834
url = models.URLField(max_length=2000, null=True)
28352835
source = models.CharField(max_length=100, default='Generic')

dojo/notifications/helper.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ def send_alert_notification(event, user=None, *args, **kwargs):
272272
icon = kwargs.get('icon', 'info-circle')
273273
alert = Alerts(
274274
user_id=user,
275-
title=kwargs.get('title')[:100],
275+
title=kwargs.get('title')[:250],
276276
description=create_notification_message(event, user, 'alert', *args, **kwargs)[:2000],
277277
url=kwargs.get('url', reverse('alerts')),
278278
icon=icon[:25],
@@ -331,8 +331,8 @@ def log_alert(e, notification_type=None, *args, **kwargs):
331331
for user in users:
332332
alert = Alerts(
333333
user_id=user,
334-
url=kwargs.get('url', reverse('alerts'))[:100],
335-
title=kwargs.get('title', 'Notification issue'),
334+
url=kwargs.get('url', reverse('alerts')),
335+
title=kwargs.get('title', 'Notification issue')[:250],
336336
description=kwargs.get('description', '%s' % e)[:2000],
337337
icon="exclamation-triangle",
338338
source=notification_type[:100] if notification_type else kwargs.get('source', 'unknown')[:100])

0 commit comments

Comments
 (0)