dont access env variables directly

g1nt0ki · g1nt0ki · commit 1dc1dd31b7cf · 2025-08-21T11:55:18.000+02:00
diff --git a/projects/SMARDEX-P2P-Lending/index.js b/projects/SMARDEX-P2P-Lending/index.js
@@ -1,8 +1,4 @@
-const headers = {
-  origin: "https://subgraph.smardex.io",
-  referer: "https://subgraph.smardex.io",
-  "x-api-key": process.env.SMARDEX_SUBGRAPH_API_KEY,
-};
+const { getEnv } = require("../helper/env");
 
 const subgraphUrl = "https://subgraph.smardex.io/ethereum/spro";
 
@@ -17,7 +13,11 @@ const getTokenMetrics = async () => {
 
   const result = await fetch(subgraphUrl, {
     method: "POST",
-    headers,
+    headers: {
+      origin: "https://subgraph.smardex.io",
+      referer: "https://subgraph.smardex.io",
+      "x-api-key": getEnv('SMARDEX_SUBGRAPH_API_KEY'),
+    },
     body: JSON.stringify({
       query: tokenMetricsQuery,
     }),
diff --git a/projects/helper/allium.js b/projects/helper/allium.js
@@ -9,26 +9,26 @@ const rateLimited = (fn) => (...args) => _rateLimited(() => fn(...args))
 
 const token = {}
 
-const HEADERS = {
+const HEADERS = () => ({
     "Content-Type": "application/json",
-    "X-API-KEY": process.env.ALLIUM_API_KEY,
-};
+    "X-API-KEY": getEnv('ALLIUM_API_KEY'),
+})
 
 async function startAlliumQuery(sqlQuery) {
     const query = await axios.post(`https://api.allium.so/api/v1/explorer/queries/phBjLzIZ8uUIDlp0dD3N/run-async`, {
         parameters: {
             fullQuery: sqlQuery
         }
     }, {
-        headers: HEADERS
+        headers: HEADERS()
     })
 
     return query.data["run_id"]
 }
 
 async function retrieveAlliumResults(queryId) {
     const results = await axios.get(`https://api.allium.so/api/v1/explorer/query-runs/${queryId}/results?f=json`, {
-        headers: HEADERS
+        headers: HEADERS()
     })
     return results.data.data
 }
@@ -50,7 +50,7 @@ async function _queryAllium(sqlQuery) {
             }
 
             const statusReq = await axios.get(`https://api.allium.so/api/v1/explorer/query-runs/${token[sqlQuery]}/status`, {
-                headers: HEADERS
+                headers: HEADERS()
             })
 
             const status = statusReq.data
diff --git a/projects/helper/env.js b/projects/helper/env.js
@@ -2,6 +2,8 @@
 const BOOL_KEYS = [
   'HISTORICAL',
   'LLAMA_DEBUG_MODE',
+  'STORE_IN_R2',
+  'IS_RUN_FROM_CUSTOM_JOB',
 ]
 
 const _yek = "b523cf66-7a5a-4fe8-8d67-f604fd0492c2"  // bifrost
@@ -60,7 +62,10 @@ const ENV_KEYS = [
   'RPC_PROXY_URL',
   'BLACKSAIL_API_KEY',
   'BITCOIN_CACHE_API',
-  'DEBANK_API_KEY'
+  'DEBANK_API_KEY',
+  'SMARDEX_SUBGRAPH_API_KEY',
+  'PROXY_AUTH',
+  'ALLIUM_API_KEY',
 ]
 
 Object.keys(DEFAULTS).forEach(i => {
diff --git a/projects/helper/proxyRequest.js b/projects/helper/proxyRequest.js
@@ -1,5 +1,6 @@
 const axios = require('axios');
 const https = require('https');
+const { getEnv } = require('./env');
 
 const agent = new https.Agent({
     rejectUnauthorized: false
@@ -12,7 +13,7 @@ async function fetchThroughProxy(rawUrl) {
         url: `https://pr.oxylabs.io:7777${url.pathname}${url.search}`,
         httpsAgent: agent,
         headers: {
-            'Proxy-Authorization': 'Basic ' + Buffer.from(`${process.env.PROXY_AUTH}`).toString('base64'),
+            'Proxy-Authorization': 'Basic ' + Buffer.from(getEnv('PROXY_AUTH')).toString('base64'),
             Host: url.host
         }
     });
diff --git a/projects/helper/token.js b/projects/helper/token.js
@@ -146,36 +146,6 @@ async function ankrGetTokens(address, { onlyWhitelisted = true, skipCacheRead =
   }
 }
 
-async function getETHTokens(address, onlyWhitelisted) {
-  const endpoint = getEnv('ETHEREUM_TOKENS_ENDPOINT')
-  if (!endpoint) throw new Error('Missing endpoint for ethereum tokens')
-  const url = `${endpoint}/v1/1/address/${address}/balances_v2/`
-  const { data: { items } } = await get(url)
-  const tokenSet = new Set()
-  items.forEach(i => {
-    const token = i.native_token ? ADDRESSES.null : i.contract_address
-    if (i.is_spam && onlyWhitelisted) return;
-    tokenSet.add(token)
-  })
-  return Array.from(tokenSet)
-}
-
-async function getComplexTreasury(owners) {
-  const networks = ["ethereum", "polygon", "optimism", "gnosis", "binance-smart-chain", "fantom", "avalanche", "arbitrum",
-    "celo", "harmony", "moonriver", "bitcoin", "cronos", "aurora", "evmos"]
-  const data = await axios.get(`https://api.zapper.xyz/v2/balances/apps?${owners.map(a => `addresses=${a}`).join("&")}&${networks.map(a => `networks=${a}`).join("&")}`, {
-    headers: {
-      Authorization: `Basic ${btoa(process.env.ZAPPER_API_KEY)}`
-    }
-  })
-  let sum = 0
-  data.data.forEach(d => {
-    sum += d.balanceUSD
-  })
-  return sum
-}
-
-
 module.exports = {
   covalentGetTokens,
   ankrChainMapping,
diff --git a/projects/p2p-lending/index.js b/projects/p2p-lending/index.js
@@ -1,8 +1,4 @@
-const headers = {
-  origin: "https://subgraph.smardex.io",
-  referer: "https://subgraph.smardex.io",
-  "x-api-key": process.env.SMARDEX_SUBGRAPH_API_KEY,
-};
+const { getEnv } = require("../helper/env");
 
 const subgraphUrl = "https://subgraph.smardex.io/ethereum/spro";
 
@@ -17,7 +13,11 @@ const getTokenMetrics = async () => {
 
   const result = await fetch(subgraphUrl, {
     method: "POST",
-    headers,
+    headers: {
+      origin: "https://subgraph.smardex.io",
+      referer: "https://subgraph.smardex.io",
+      "x-api-key": getEnv('SMARDEX_SUBGRAPH_API_KEY'),
+    },
     body: JSON.stringify({
       query: tokenMetricsQuery,
     }),
diff --git a/projects/uniswap-v4/index.js b/projects/uniswap-v4/index.js
@@ -1,6 +1,7 @@
 const { sumTokens2 } = require("../helper/unwrapLPs");
 const { getLogs2 } = require('../helper/cache/getLogs');
 const { nullAddress } = require("../helper/tokenMapping");
+const { getEnv } = require("../helper/env");
 
 // from https://docs.uniswap.org/contracts/v4/deployments
 const config = {
@@ -25,7 +26,7 @@ Object.keys(config).forEach(chain => {
   const { factory, fromBlock } = config[chain]
   module.exports[chain] = {
     tvl: async (api) => {
-      if (!process.env.IS_RUN_FROM_CUSTOM_JOB) throw new Error('This job is not meant to be run directly, please use the custom job feature')
+      if (!getEnv('IS_RUN_FROM_CUSTOM_JOB')) throw new Error('This job is not meant to be run directly, please use the custom job feature')
 
       let compressType
       if (chain === 'base') compressType = 'v1'
diff --git a/utils/scripts/checkBTCDupsv2.js b/utils/scripts/checkBTCDupsv2.js
@@ -1,12 +1,11 @@
 const sdk = require('@defillama/sdk')
 const addressBook = require('../../projects/helper/bitcoin-book/index');
+const { getEnv } = require('../../projects/helper/env');
 const Bucket = "tvl-adapter-cache";
 
 console.log('project count: ', Object.keys(addressBook).length);
 const addressProjectMap = {}
 
-const storeInR2 = !!process.env.STORE_IN_R2
-
 const projectData = {}
 
 async function run() {
@@ -20,7 +19,7 @@ async function run() {
       if (!Array.isArray(addresses)) addresses = await addresses()
 
 
-      if (storeInR2) {
+      if (getEnv('STORE_IN_R2')) {
         projectData[project] = addresses
         return;
       }
@@ -43,7 +42,7 @@ async function run() {
 
 
 
-  if (storeInR2) {
+  if (getEnv('STORE_IN_R2')) {
     try {
       await sdk.cache.writeCache(`${Bucket}/bitcoin-addresses.json`, projectData)
       console.log('data written to s3 bucket');
