-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Winnieswap improvements #16928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winnieswap improvements #16928
Conversation
…ol detection - Add AutoWin vaults (auto-compounding ERC-4626 vaults) to TVL calculation - Use getUnderlyingBalances() for accurate liquidity tracking (similar to Kodiak v3) - Reduce fromBlock from 7402487 to 2500000 to capture early pools including NECT-HONEY - Improve architecture with separate functions for sticky vaults and autowin vaults
|
It seems like these vaults are holding dex LP tokens? Is that right? In that case this would be double counting and we cant re-count these |
|
@waynebruce0x yes indeed but for example if you look at the current winnieswap dashboard on defillama, the counting is correct even tho you have already
the added autowin vaults are just new lp tokens (aw lp tokens) also we fixed the time to have the nect/honey counted as we don't see it counted in the dasboard and now should be visible |
|
So a user will deposit funds to a pool, then take that LP receipt token and deposit that to a sticky vault or autowin vault? Or are these vaults holding LP tokens from elsewhere? |
|
The user can
these can't be stake in the same vault, you can stake them in separated vaults like on BEX or Infrared for example |
|
so it's good? @waynebruce0x |
|
It seems like the vaults are just double counting the same underlying assets in the liquidity pools, in which case we cant include this as TVL |
|
Alright just changed the block to have all our pools included, should be good now @waynebruce0x |
|
The adapter at projects/winnieswap exports TVL: |
|
there is still a problem, the vault https://www.winnieswap.com/vault/0xa5b3ecafbfcc7946c11a28252c6f2bdb73d30388 isn't included in the data reported... |
|
I think this might be a caching issue - I will merge this now and keep an eye on the issue |
Initial PR: #16165
Improvements adding