l2 - v2 code review #10809
Open
l2 - v2 code review #10809
+41
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const filteredAddresses: { [chain: Chain]: Address[] } = {}; | ||
|
|
||
| const tokenAddresses = async (): Promise<{ [chain: Chain]: Address[] }> => { | ||
| //QUESTION: how are the errors here handled? |
Collaborator
There was a problem hiding this comment.
right now theyre handled down stream
Member
Author
There was a problem hiding this comment.
unless you are checking for error objects in promisePool, they get ignored
Member
Author
There was a problem hiding this comment.
that is something I hate about promisePool, if you use our sdk one, it throws error: https://github.com/DefiLlama/defillama-sdk/blob/more-chainApi-methods/src/util/promisePool.ts#L5
| // isnt this a lot of writes? | ||
| prices = await getR2JSONString(`prices/${chain}.json`); | ||
| } catch (e) { | ||
| // QUESTION: hmm, what does happen if the price is already cached? are you deleting old prices somewhere else in the code? |
Collaborator
There was a problem hiding this comment.
this is just for debug while the works in dev
Collaborator
There was a problem hiding this comment.
same with the other R2s below, theyre cached for ages but it speeds up the process significantly for debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.