Fix mypy error: cast icon return value to str

Author: DefinitelyADev

custom_components/rooms/config_flow.py

@@ -13,11 +13,13 @@
     CONF_CLIMATE_ENTITY,
     CONF_ENERGY_ENTITY,
     CONF_HUMIDITY_ENTITY,
+    CONF_ICON,
     CONF_MOTION_ENTITY,
     CONF_POWER_ENTITY,
     CONF_ROOM_NAME,
     CONF_TEMP_ENTITY,
     CONF_WINDOW_ENTITY,
+    DEFAULT_ICON,
     DOMAIN,
 )
 
@@ -55,6 +57,7 @@ async def async_step_user(self, user_input: Optional[Dict[str, Any]] = None) ->
             data_schema=vol.Schema(
                 {
                     vol.Required(CONF_ROOM_NAME): str,
+                    vol.Optional(CONF_ICON, default=DEFAULT_ICON): str,
                     vol.Optional(CONF_POWER_ENTITY): selector.EntitySelector(
                         selector.EntitySelectorConfig(domain="sensor")
                     ),

custom_components/rooms/const.py

@@ -10,9 +10,11 @@
 CONF_WINDOW_ENTITY = "window_entity"
 CONF_CLIMATE_ENTITY = "climate_entity"
 CONF_ACTIVE_THRESHOLD = "active_threshold"
+CONF_ICON = "icon"
 
 # Default values
 DEFAULT_ACTIVE_THRESHOLD = 50.0
+DEFAULT_ICON = "mdi:texture-box"
 
 # State values
 STATE_ACTIVE = "active"

custom_components/rooms/sensor.py

@@ -38,14 +38,15 @@
     CONF_CLIMATE_ENTITY,
     CONF_ENERGY_ENTITY,
     CONF_HUMIDITY_ENTITY,
+    CONF_ICON,
     CONF_MOTION_ENTITY,
     CONF_POWER_ENTITY,
     CONF_ROOM_NAME,
     CONF_TEMP_ENTITY,
     CONF_WINDOW_ENTITY,
     DEFAULT_ACTIVE_THRESHOLD,
+    DEFAULT_ICON,
     DOMAIN,
-    ICON_HOME,
     ICON_MOTION,
     ICON_WINDOW_OPEN,
     STATE_ACTIVE,
@@ -243,7 +244,8 @@ def icon(self) -> str:
             if motion_state and motion_state.state == STATE_ON:
                 return ICON_MOTION
 
-        return ICON_HOME
+        # Return configured icon or default
+        return str(data.get(CONF_ICON, DEFAULT_ICON))
 
     @property
     def extra_state_attributes(self) -> Dict[str, Any]:

custom_components/rooms/tests/test_sensor.py

@@ -61,7 +61,7 @@ def test_room_summary_sensor_initialization(mock_coordinator, mock_config_entry,
     sensor.hass = mock_hass
 
     assert sensor.name == "Test Room"
-    assert sensor.unique_id == "test_entry_id_summary"
+    assert sensor.unique_id == "room_test_entry_id_summary"
     assert sensor.should_poll is False
 
 
@@ -211,7 +211,7 @@ def mock_get(entity_id):
 
     mock_hass.states.get = mock_get
 
-    assert sensor.icon == "mdi:home"
+    assert sensor.icon == "mdi:texture-box"
 
     # Test motion icon
     motion_state.state = STATE_ON