Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Commit 024d887

Browse files
committed
Ensure posting the welcome comment first
I'm not sure that this is enough to actually having it appear first, but it doesn't hurt to try...
1 parent a00662f commit 024d887

24 files changed

+110
-109
lines changed

β€Žsrc/_tests/fixtures/43160/mutations.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"variables": {
2525
"input": {
2626
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5MDYwOTQ4",
27-
"body": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***\n<!--typescript_bot_suggest-testing-->"
27+
"body": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` β€” [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43160&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have failed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
2828
}
2929
}
3030
},
@@ -33,7 +33,7 @@
3333
"variables": {
3434
"input": {
3535
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5MDYwOTQ4",
36-
"body": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` β€” [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43160&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have failed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
36+
"body": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***\n<!--typescript_bot_suggest-testing-->"
3737
}
3838
}
3939
},

β€Žsrc/_tests/fixtures/43160/result.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66
"Untested Change"
77
],
88
"responseComments": [
9-
{
10-
"tag": "suggest-testing",
11-
"status": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***"
12-
},
139
{
1410
"tag": "welcome",
1511
"status": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` β€” [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43160&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have failed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
1612
},
13+
{
14+
"tag": "suggest-testing",
15+
"status": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***"
16+
},
1717
{
1818
"tag": "gh-actions-complaint-6d5d2a8",
1919
"status": "@rikkertkoppes The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/22c73c88cc9c09efd4c2998ec360607dd4c36c2e/checks?check_suite_id=731664306).\n\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n\n**Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.**"

β€Žsrc/_tests/fixtures/43175/mutations.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"variables": {
1414
"input": {
1515
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5NzQ2Mjcx",
16-
"body": "Hey @ankhler,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***\n<!--typescript_bot_suggest-testing-->"
16+
"body": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` β€” [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43175&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
1717
}
1818
}
1919
},
@@ -22,7 +22,7 @@
2222
"variables": {
2323
"input": {
2424
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5NzQ2Mjcx",
25-
"body": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` β€” [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43175&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
25+
"body": "Hey @ankhler,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***\n<!--typescript_bot_suggest-testing-->"
2626
}
2727
}
2828
},

β€Žsrc/_tests/fixtures/43175/result.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
"Untested Change"
66
],
77
"responseComments": [
8-
{
9-
"tag": "suggest-testing",
10-
"status": "Hey @ankhler,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***"
11-
},
128
{
139
"tag": "welcome",
1410
"status": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` β€” [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=43175&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
1511
},
12+
{
13+
"tag": "suggest-testing",
14+
"status": "Hey @ankhler,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***"
15+
},
1616
{
1717
"tag": "pinging-reviewers",
1818
"status": "πŸ”” @matthewkimber @otiai10 @couven92 @rreverser @sreimer15 @MatCarlson @ekinsol @tregagnon @echoabstract @spasma β€” please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43175/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on."

β€Žsrc/_tests/fixtures/44267/mutations.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,20 @@
3131
}
3232
},
3333
{
34-
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
34+
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
3535
"variables": {
3636
"input": {
37-
"subjectId": "MDExOlB1bGxSZXF1ZXN0NDA5NTQyNDky",
38-
"body": "Hey @ErikMartensson,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***\n<!--typescript_bot_suggest-testing-->"
37+
"id": "MDEyOklzc3VlQ29tbWVudDYyMDQxNTE4Mw==",
38+
"body": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` β€” [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=44267&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
3939
}
4040
}
4141
},
4242
{
43-
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
43+
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
4444
"variables": {
4545
"input": {
46-
"id": "MDEyOklzc3VlQ29tbWVudDYyMDQxNTE4Mw==",
47-
"body": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` β€” [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=44267&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
46+
"subjectId": "MDExOlB1bGxSZXF1ZXN0NDA5NTQyNDky",
47+
"body": "Hey @ErikMartensson,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***\n<!--typescript_bot_suggest-testing-->"
4848
}
4949
}
5050
}

β€Žsrc/_tests/fixtures/44267/result.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
"Untested Change"
66
],
77
"responseComments": [
8-
{
9-
"tag": "suggest-testing",
10-
"status": "Hey @ErikMartensson,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***"
11-
},
128
{
139
"tag": "welcome",
1410
"status": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` β€” [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes in this [PR in the Playground](https://www.typescriptlang.org/play/?dtPR=44267&install-plugin=playground-dt-review).\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * πŸ• Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
11+
},
12+
{
13+
"tag": "suggest-testing",
14+
"status": "Hey @ErikMartensson,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.\n\n***This can potentially save days of time for you!***"
1515
}
1616
],
1717
"shouldClose": false,

0 commit comments

Comments
Β (0)