Add comma-dangle ESLint rule (#347)

And fix some commas as a result.

Author: jablko

.eslintrc.json

@@ -32,6 +32,7 @@
           "ArrayExpression": "first",
           "ignoredNodes": ["ConditionalExpression", "TemplateLiteral > *"]
         }],
+        "comma-dangle": ["error", "only-multiline"],
         "no-constant-condition": ["error", { "checkLoops": false }],
         "no-useless-escape": "off",
         "@typescript-eslint/explicit-module-boundary-types": "off",

src/_tests/fixturedActions.test.ts

@@ -9,7 +9,7 @@ import { scrubDiagnosticDetails } from "../util/util";
 import * as cachedQueries from "./cachedQueries.json";
 jest.mock("../util/cachedQueries", () => ({
     getProjectBoardColumns: jest.fn(() => cachedQueries.getProjectBoardColumns),
-    getLabels: jest.fn(() => cachedQueries.getLabels)
+    getLabels: jest.fn(() => cachedQueries.getLabels),
 }));
 import { executePrActions } from "../execute-pr-actions";
 
@@ -42,7 +42,7 @@ async function testFixture(dir: string) {
         prInfo,
         (expr: string) => Promise.resolve(files[expr] as string),
         (name: string, _until?: Date) => name in downloads ? downloads[name] : 0,
-        new Date(readJsonSync(derivedPath).now)
+        new Date(readJsonSync(derivedPath).now),
     );
 
     const action = process(derived);

src/compute-pr-actions.ts

@@ -45,7 +45,7 @@ export const LabelNames = [
     "Too Many Owners",
     "Untested Change",
     "Check Config",
-    ...StalenessKinds
+    ...StalenessKinds,
 ] as const;
 
 export interface Actions {
@@ -173,7 +173,7 @@ function extendPrInfo(info: PrInfo): ExtendedPrInfo {
         requireMaintainer, blessable, failedCI, staleness,
         packages, hasMultiplePackages, hasDefinitions, hasTests, isUntested, newPackages, hasNewPackages, hasEditedPackages,
         approvedReviews, changereqReviews, staleReviews, approvedBy, hasChangereqs,
-        needsAuthorAction, reviewColumn, isAuthor
+        needsAuthorAction, reviewColumn, isAuthor,
     };
 
     // Staleness timeline configurations (except for texts that are all in `comments.ts`)
@@ -237,12 +237,12 @@ export function process(prInfo: BotResult,
             return {
                 ...createEmptyActions(),
                 targetColumn: "Needs Author Action",
-                shouldUpdateProjectColumn: true
+                shouldUpdateProjectColumn: true,
             };
         } else {
             return {
                 ...createEmptyActions(),
-                shouldRemoveFromActiveColumns: true
+                shouldRemoveFromActiveColumns: true,
             };
         }
     }

src/execute-pr-actions.ts

@@ -36,7 +36,7 @@ async function getMutationsForLabels(actions: Actions, pr: PR_repository_pullReq
         return labels.length === 0 ? null
             : createMutation<schema.AddLabelsToLabelableInput & schema.RemoveLabelsFromLabelableInput>(query, {
                 labelIds: await Promise.all(labels.map(label => getLabelIdByName(label))),
-                labelableId: pr.id, });
+                labelableId: pr.id });
     };
     return Promise.all([
         makeMutations((label => !labels.includes(label) && actions.labels.includes(label)), "addLabelsToLabelable"),
@@ -113,7 +113,7 @@ function getMutationsForChangingPRState(actions: Actions, pr: PR_repository_pull
             : null,
         actions.shouldClose
             ? createMutation<schema.ClosePullRequestInput>("closePullRequest", { pullRequestId: pr.id })
-            : null
+            : null,
     ];
 }
 

src/graphql-client.ts

@@ -5,7 +5,7 @@ import * as schema from "@octokit/graphql-schema/schema";
 
 const headers = {
     authorization: `Bearer ${getAuthToken()}`,
-    accept: "application/vnd.github.antiope-preview+json"
+    accept: "application/vnd.github.antiope-preview+json",
 };
 
 const uri = "https://api.github.com/graphql";

src/pr-info.ts

@@ -6,7 +6,7 @@ import { PR_repository_pullRequest as GraphqlPullRequest,
          PR_repository_pullRequest_timelineItems_nodes_ReopenedEvent,
          PR_repository_pullRequest_timelineItems_nodes_ReadyForReviewEvent,
          PR_repository_pullRequest_timelineItems_nodes_MovedColumnsInProjectEvent,
-         PR_repository_pullRequest_comments_nodes
+         PR_repository_pullRequest_comments_nodes,
 } from "./queries/schema/PR";
 import { getMonthlyDownloadCount } from "./util/npm";
 import { client } from "./graphql-client";
@@ -230,7 +230,7 @@ export async function deriveStateForPR(
         popularityLevel,
         pkgInfo,
         reviews,
-        ...getCIResult(headCommit.checkSuites)
+        ...getCIResult(headCommit.checkSuites),
     };
 
     function botError(message: string): BotError {
@@ -354,7 +354,7 @@ const configSuspicious = <ConfigSuspicious>(async (path, getContents) => {
 configSuspicious["OTHER_FILES.txt"] = makeChecker(
     [],
     urls.otherFilesTxt,
-    { parse: text => text.split(/\r?\n/) },
+    { parse: text => text.split(/\r?\n/) }
 );
 configSuspicious["package.json"] = makeChecker(
     { private: true },
@@ -363,7 +363,7 @@ configSuspicious["package.json"] = makeChecker(
         delete data.dependencies;
         delete data.types;
         delete data.typesVersions;
-    } },
+    } }
 );
 configSuspicious["tslint.json"] = makeChecker(
     { extends: "dtslint/dt.json" },
@@ -380,7 +380,7 @@ configSuspicious["tsconfig.json"] = makeChecker(
             strictNullChecks: true,
             types: [],
             noEmit: true,
-            forceConsistentCasingInFileNames: true
+            forceConsistentCasingInFileNames: true,
         }
     },
     urls.tsconfigJson,
@@ -390,7 +390,7 @@ configSuspicious["tsconfig.json"] = makeChecker(
         delete data.compilerOptions.typeRoots;
         delete data.compilerOptions.paths;
         delete data.files;
-    } },
+    } }
 );
 
 // helper for file checkers: allow either a given "expectedForm", or any edits that get closer

src/pr-trigger.ts

@@ -47,7 +47,7 @@ export async function httpTrigger(context: Context, req: HttpRequest) {
         "pull_request_review": ["submitted", "dismissed"],
         "issue_comment": ["created", "edited", "deleted"],
         "project_card": ["moved"],
-        "check_suite": ["completed"]
+        "check_suite": ["completed"],
     };
     const allowListedActions = acceptedEventsToActions[event];
 

src/queries/all-open-prs-query.ts

@@ -28,7 +28,7 @@ export async function getAllOpenPRsAndCardIDs() {
         const result = await client.query({
             query: getAllOpenPRsAndCardIDsQuery,
             fetchPolicy: "no-cache",
-            variables: { endCursor }
+            variables: { endCursor },
         });
         prNumbers.push(...noNullish(result.data.repository?.pullRequests.nodes).map(pr => pr.number));
         for (const pr of noNullish(result.data.repository?.pullRequests.nodes)) {

src/queries/projectboard-cards.ts

@@ -55,7 +55,7 @@ export async function getProjectBoardCards() {
         columns.push({
             name: col.name,
             totalCount: col.cards.totalCount,
-            cards
+            cards,
         });
     });
 

src/scripts/updateJSONFixtures.ts

@@ -25,13 +25,13 @@ fixtureNames.forEach(fixture => {
     headCommit.checkSuites.nodes.push({
         "app": {
             "name": "GitHub Actions",
-            "__typename": "App"
+            "__typename": "App",
         },
         "conclusion": status,
         "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/22c73c88cc9c09efd4c2998ec360607dd4c36c2e/checks?check_suite_id=731664306",
         "status": status,
         "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/22c73c88cc9c09efd4c2998ec360607dd4c36c2e/checks?check_suite_id=731664306",
-        "__typename": "CheckSuite"
+        "__typename": "CheckSuite",
     });
 
     writeFileSync(responsePath, JSON.stringify(response, null, "  ") + "\n", "utf8");