Move the sha256 bit to util/util.ts

Author: elibarzilay

src/comments.ts

@@ -1,4 +1,4 @@
-import crypto = require("crypto");
+import { sha256 } from "./util/util";
 
 export type Comment = { tag: string, status: string };
 
@@ -65,7 +65,7 @@ ${names.map(n => `${n}`).join(" ")}
 });
 
 export const PingStaleReviewer = (reviewedAbbrOid: string, reviewers: string[]) => ({
-    tag: `stale-ping-${tinyHash(reviewers.join("-"))}-${reviewedAbbrOid}`,
+    tag: `stale-ping-${sha256(reviewers.join("-")).substr(0, 6)}-${reviewedAbbrOid}`,
     status: `@${reviewers.join(", @")} Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?`
 });
 
@@ -91,7 +91,3 @@ I can't [accept a merge request](${uri}) until the PR has a green CI and was app
 
 Thanks, and happy typing!`
 });
-
-function tinyHash(s: string): string {
-    return crypto.createHash("sha256").update(s).digest("hex").substr(0, 6);
-}

src/compute-pr-actions.ts

@@ -2,8 +2,7 @@ import * as Comments from "./comments";
 import { PrInfo, BotError, BotEnsureRemovedFromProject, BotNoPackages, FileInfo } from "./pr-info";
 import { CIResult } from "./util/CIResult";
 import { ReviewInfo } from "./pr-info";
-import { noNulls, flatten, unique, sameUser, daysSince } from "./util/util";
-import * as crypto from "crypto";
+import { noNulls, flatten, unique, sameUser, daysSince, sha256 } from "./util/util";
 
 type ColumnName =
     | "Needs Maintainer Action"
@@ -496,7 +495,8 @@ function createWelcomeComment(info: ExtendedPrInfo) {
 
     const approved = emoji(info.approved);
     const reviewLink = (f: FileInfo) =>
-        `[\`${f.path.replace(/^types\/(.*\/)/, "$1")}\`](${uriForReview(info.pr_number)}/${info.headCommitOid}#diff-${crypto.createHash("sha256").update(f.path).digest("hex")})`;
+        `[\`${f.path.replace(/^types\/(.*\/)/, "$1")}\`](${
+          uriForReview(info.pr_number)}/${info.headCommitOid}#diff-${sha256(f.path)})`;
 
     if (info.hasNewPackages) {
         display(` * ${approved} Only ${requiredApprover} can approve changes when there are new packages added`);

src/util/util.ts

@@ -1,4 +1,5 @@
-import moment = require("moment");
+import * as crypto from "crypto";
+import * as moment from "moment";
 
 export function noNulls<T>(arr: ReadonlyArray<T | null | undefined> | null | undefined): T[] {
     if (arr == null) return [];
@@ -75,3 +76,7 @@ export function authorNotBot(node: { login: string } | { author?: { login: strin
 export function scrubDiagnosticDetails(s: string) {
     return s.replace(/<details><summary>Diagnostic Information.*?<\/summary>(?:\\n)+```json\\n{.*?\\n}\\n```(?:\\n)+<\/details>/sg, "... diagnostics scrubbed ...");
 }
+
+export function sha256(s: string) {
+    return crypto.createHash("sha256").update(s).digest("hex")
+}