Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Commit 97837e0

Browse files
authored
Merge pull request #284 from elibarzilay/fix-readme-links
Fix `README.md` links
2 parents 890fc4b + 46e53ba commit 97837e0

34 files changed

+57
-54
lines changed

β€Žsrc/_tests/fixtures/43160/mutations.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"variables": {
2525
"input": {
2626
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5MDYwOTQ4",
27-
"body": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n<!--typescript_bot_suggest-testing-->"
27+
"body": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n<!--typescript_bot_suggest-testing-->"
2828
}
2929
}
3030
},
@@ -33,7 +33,7 @@
3333
"variables": {
3434
"input": {
3535
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5MDYwOTQ4",
36-
"body": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
36+
"body": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
3737
}
3838
}
3939
},

β€Žsrc/_tests/fixtures/43160/result.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99
"responseComments": [
1010
{
1111
"tag": "suggest-testing",
12-
"status": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you."
12+
"status": "Hey @rikkertkoppes,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you."
1313
},
1414
{
1515
"tag": "welcome",
16-
"status": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
16+
"status": "@rikkertkoppes Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `dagre` [on npm](https://www.npmjs.com/package/dagre), [on unpkg](https://unpkg.com/browse/dagre@latest/)\n - owner-approval: @rustedgrail\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
1717
},
1818
{
1919
"tag": "gh-actions-complaint-6d5d2a8",

β€Žsrc/_tests/fixtures/43175/mutations.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"variables": {
1414
"input": {
1515
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5NzQ2Mjcx",
16-
"body": "Hey @ankhler,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n<!--typescript_bot_suggest-testing-->"
16+
"body": "Hey @ankhler,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n<!--typescript_bot_suggest-testing-->"
1717
}
1818
}
1919
},
@@ -22,7 +22,7 @@
2222
"variables": {
2323
"input": {
2424
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5NzQ2Mjcx",
25-
"body": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
25+
"body": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
2626
}
2727
}
2828
},

β€Žsrc/_tests/fixtures/43175/result.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
"responseComments": [
99
{
1010
"tag": "suggest-testing",
11-
"status": "Hey @ankhler,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you."
11+
"status": "Hey @ankhler,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you."
1212
},
1313
{
1414
"tag": "welcome",
15-
"status": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
15+
"status": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
1616
},
1717
{
1818
"tag": "pinging-reviewers",

β€Žsrc/_tests/fixtures/44267/mutations.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"variables": {
3636
"input": {
3737
"subjectId": "MDExOlB1bGxSZXF1ZXN0NDA5NTQyNDky",
38-
"body": "Hey @ErikMartensson,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n<!--typescript_bot_suggest-testing-->"
38+
"body": "Hey @ErikMartensson,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n<!--typescript_bot_suggest-testing-->"
3939
}
4040
}
4141
},
@@ -44,7 +44,7 @@
4444
"variables": {
4545
"input": {
4646
"id": "MDEyOklzc3VlQ29tbWVudDYyMDQxNTE4Mw==",
47-
"body": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
47+
"body": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
4848
}
4949
}
5050
}

β€Žsrc/_tests/fixtures/44267/result.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
"responseComments": [
99
{
1010
"tag": "suggest-testing",
11-
"status": "Hey @ErikMartensson,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you."
11+
"status": "Hey @ErikMartensson,\n\n:unamused: Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package) to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you."
1212
},
1313
{
1414
"tag": "welcome",
15-
"status": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
15+
"status": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped πŸ‘‹ β€” I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * βœ… No merge conflicts\n * βœ… Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
1616
}
1717
],
1818
"shouldClose": false,

0 commit comments

Comments
Β (0)